Fix incomplete path traversal check in FileResponse (nwu + nwu2)#1749
Closed
Fix incomplete path traversal check in FileResponse (nwu + nwu2)#1749
Conversation
Merged
…onse.java (nwu and nwu2) Co-authored-by: nmaguiar <11761746+nmaguiar@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback from review on pull request T8
Fix incomplete path traversal check in FileResponse (nwu + nwu2)
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
..traversal guard only checked../(forward slash), missing..\(Windows backslash separator). While the canonical path comparison is the authoritative defense, the explicit check should be comprehensive on all platforms.Changes
src/com/nwu/httpd/responses/FileResponse.javaandsrc/com/nwu2/httpd/responses/FileResponse.java|| relativeUri.indexOf(".." + File.separator) >= 0to block backslash-based traversal sequences"Won't serve ../ for security reasons."→"Won't serve .. paths for security reasons."to be platform-agnostic✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.