Open
Conversation
andrsd
reviewed
Jul 1, 2025
andrsd
suggested changes
Jul 1, 2025
| opensnpy::console.BindModule(WrapDiffusion); | ||
|
|
||
| opensnpy::console.BindModule(WrapPostProcessor); | ||
| opensnpy::console.BindModule(WrapPrinter); |
There was a problem hiding this comment.
The way this should probably work is that we call the binding function from OpenSn (rather than copying that). Then, add the application wrappers like WrapDiffusion
| @@ -0,0 +1,577 @@ | |||
| """Module providing regression output checking.""" | |||
There was a problem hiding this comment.
I am gonna comment on this here. I assume the test suite was copied into the app so we could run tests. Would there be a way to use the test suite from OpenSn. I does have flags like --exe, -d, etc. but may be this is more convenient?
Contributor
Author
There was a problem hiding this comment.
It is possible to use the test infrastructure from OpenSn. I don't have a strong opinion as to which way is best
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the diffusion module from OpenSn to a standalone application