Skip to content

Fix potential protocol mismatch and exploit for plugin message channel#86

Merged
TheMeinerLP merged 1 commit intomasterfrom
bugfix/plugin-message-channel
Oct 30, 2024
Merged

Fix potential protocol mismatch and exploit for plugin message channel#86
TheMeinerLP merged 1 commit intomasterfrom
bugfix/plugin-message-channel

Conversation

@TheMeinerLP
Copy link
Collaborator

Proposed changes

This pr fixes a huge bug for interaction with minecaft client and some proxies solutions.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

@TheMeinerLP TheMeinerLP requested a review from a team as a code owner October 28, 2024 11:42
@TheMeinerLP TheMeinerLP added bug Something isn't working hacktoberfest Only be used during the Hacktoberfest hacktoberfest-accepted labels Oct 28, 2024
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
33.3% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

@theEvilReaper theEvilReaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheMeinerLP TheMeinerLP merged commit c239e4e into master Oct 30, 2024
@TheMeinerLP TheMeinerLP deleted the bugfix/plugin-message-channel branch October 30, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Bugfix hacktoberfest Only be used during the Hacktoberfest hacktoberfest-accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants