Send explosions only to nearby players

[joelramilison]

Proposed changes

Explosion packets are now only sent to nearby players to improve performance.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

• I have read the CONTRIBUTING.md
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Further comments

Fixes issue #64

[TheMeinerLP]

Can you try to re-implement also a test for that behaviour ?

[OneLiteFeather]

Looks good to me

[OneLiteFeather]

Can you try to re-implement also a test for that behaviour ?

That would be beneficial to do so, I would also welcome that if @joelramilison wants to add this

[TheMeinerLP]

Looks good to me

The problem is, we can't approve it because the pipelines fails

[joelramilison]

What would a unit test for that look like, what are you thinking of? I'm asking because the code changes were quite minimal, the getNearbyEntities function is already being tested and the rest seems quite straightforward.

[TheMeinerLP]

Regardless of whether the change is small, testing allows us to ensure that the quality remains the same in version updates. In addition, we can ensure that nothing breaks in the event of changes to other areas that may only have an indirect effect.

[TheMeinerLP]

Can you resolve the merge conflicts ?

[theEvilReaper]

LGTM

[TheMeinerLP]

We need to test the tests manually before we merge

[TheMeinerLP]

Works as planned