Skip to content

Fix wrong translated enabled features#75

Merged
Joltras merged 2 commits intomasterfrom
bugfix/enabled_features_packet
Sep 14, 2024
Merged

Fix wrong translated enabled features#75
Joltras merged 2 commits intomasterfrom
bugfix/enabled_features_packet

Conversation

@TheMeinerLP
Copy link
Collaborator

Proposed changes

This PR fixes a samll issue and add some quality testing of packet.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

Copy link

@Joltras Joltras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

@Joltras Joltras merged commit f7e573e into master Sep 14, 2024
@Joltras Joltras deleted the bugfix/enabled_features_packet branch September 14, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants