Skip to content
This repository was archived by the owner on Sep 26, 2024. It is now read-only.

Authorization Code Flow (PoC)#52

Closed
adam-mccoy wants to merge 9 commits into
mainfrom
auth-code-flow
Closed

Authorization Code Flow (PoC)#52
adam-mccoy wants to merge 9 commits into
mainfrom
auth-code-flow

Conversation

@adam-mccoy

@adam-mccoy adam-mccoy commented Jul 12, 2021

Copy link
Copy Markdown

Background

This PR is a proof-of-concept of using the OAuth2 Authorization Code flow instead of the Hybrid flow.

Tested manually using Okta - need to test the remaining providers.

How to Test

Configure the extension with Octopus Server with a client secret, e.g:

Octopus.Server.exe --configure --instance=MyInstance --OktaIsEnabled=true --OktaIssuer=https://myorg.okta.com --OktaClientId=MY_CLIENT_ID --OktaClientSecret=MY_CLIENT_SECRET

Issues to Address

  • Lots of code duplication
  • Not extensively tested
  • Does OctopusID still work?
  • Adding PKCE would be nice

@N-lson

N-lson commented May 6, 2022

Copy link
Copy Markdown
Contributor

Closing as the changes have been made + PKCE in these other PRs:
#67
#70
#71

@N-lson N-lson closed this May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants