[19.0][MIG] mail_activity_team: Migration to 19.0#153
Open
muaazsiddiq wants to merge 80 commits intoOCA:19.0from
Open
[19.0][MIG] mail_activity_team: Migration to 19.0#153muaazsiddiq wants to merge 80 commits intoOCA:19.0from
muaazsiddiq wants to merge 80 commits intoOCA:19.0from
Conversation
Currently translated at 100.0% (24 of 24 strings) Translation: social-13.0/social-13.0-mail_activity_team Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_activity_team/it/
When an activity is scheduled due to automatic processes the onchanges won't adapt the proper user team, so we could have a mismatch that provokes an exceptions due to the designed constaints
- If a user is archived but there's an automatic activity, the team check wouldn't locate him. We have to ensure the context. - When the automatic activity gets a user with no team, we should set the team to a void one as well. TT30470
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-15.0/social-15.0-mail_activity_team Translate-URL: https://translation.odoo-community.org/projects/social-15-0/social-15-0-mail_activity_team/
If you schedule an activity and you don't force the team as False, errors might araise. For example, on holidays.
Replaced for web_domain_field module
The user couldn't see the proper count of his own activities. It was allways showing the team activities counter. TT35885
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-17.0/social-17.0-mail_activity_team Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_activity_team/
Currently translated at 100.0% (34 of 34 strings) Translation: social-17.0/social-17.0-mail_activity_team Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_activity_team/it/
…exists on server actions
A monkey patch is required on mail.activity's create method to prevent an unboundError (see odoo/odoo#197864). In order to open the team activities (Late/Today/Future) from the systray widget, domain clause mangling is applied in mail.activity.mixin's web_search_read. Includes OCA/social#1469 that was not ported to 17.0 yet. Aligned ir.rule with upstream mail.activity rule wrt. creation (https://github.com/odoo/odoo/blob/b1ffd68e4094d9456dd4ae8f0fa12b50e5ce9d67/addons/mail/security/mail_security.xml#L223-L232). Co-authored-by: Wodran Van de Sande <wodran.vandesande@dynapps.be>
…s provided mail.activity's `create` checks if a value for `team_id` is being passed, and in that case drops values for `user_id`. However, a value for `team_id` will always be present in the create values because there is a default method for the field. In case all teams have been deleted, or if team selection is restricted as per customization, the value for `team_id` will still be present, but empty. In that case, we don't want the value for `user_id` to be dropped silently from the values.
mail_post_defer breaks tests for mail_tracking, so it's better to split it. OCA/social@b782115 @moduon MT-10471
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: mail-18.0/mail-18.0-mail_activity_team Translate-URL: https://translation.odoo-community.org/projects/mail-18-0/mail-18-0-mail_activity_team/
Currently translated at 100.0% (35 of 35 strings) Translation: mail-18.0/mail-18.0-mail_activity_team Translate-URL: https://translation.odoo-community.org/projects/mail-18-0/mail-18-0-mail_activity_team/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: mail-18.0/mail-18.0-mail_activity_team Translate-URL: https://translation.odoo-community.org/projects/mail-18-0/mail-18-0-mail_activity_team/
Currently translated at 100.0% (35 of 35 strings) Translation: mail-18.0/mail-18.0-mail_activity_team Translate-URL: https://translation.odoo-community.org/projects/mail-18-0/mail-18-0-mail_activity_team/it/
Member
mathiasfrancke
left a comment
There was a problem hiding this comment.
One optional change. Tests pending
| # We must consider also users that could be archived but come from | ||
| # an automatic scheduled activity | ||
| if ( | ||
| activity.user_id.id != api.SUPERUSER_ID |
Member
There was a problem hiding this comment.
(optional) we could import SUPERUSER_ID from api so we can use SUPERUSER_ID here instead of api.SUPERUSER_ID
Member
|
@muaazsiddiq Some checks are failing |
CRogos
suggested changes
Feb 24, 2026
Contributor
CRogos
left a comment
There was a problem hiding this comment.
There are several PR on v18. https://github.com/OCA/mail/pulls?q=is%3Apr+is%3Aopen+mail_activity_team
I think at least the outcome of #116 and #149 should be added before the migration.
Also the changes need to be squashed into one commit and there are also a lot of commits which could be squashed: https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate
CRogos
reviewed
Feb 24, 2026
9d12d79 to
5fe7b94
Compare
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.