[bug] Move server creation and server start in the same thread#1375
Open
hao-aaron wants to merge 1 commit intoNovaSky-AI:mainfrom
Open
[bug] Move server creation and server start in the same thread#1375hao-aaron wants to merge 1 commit intoNovaSky-AI:mainfrom
hao-aaron wants to merge 1 commit intoNovaSky-AI:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
The pull request refactors the server startup logic in skyrl/backends/skyrl_train/inference_servers/router.py. The start method's server initialization and execution, previously handled directly, are now encapsulated within a new private method, _run_server. This change improves code organization by separating the server's asynchronous execution within a background thread from the main start method's responsibilities, which now primarily handle initial setup and thread management.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.