[bug][examples] Fix lcb dataset issue in examples dir#1349
Open
s-chundi wants to merge 1 commit intoNovaSky-AI:mainfrom
Open
[bug][examples] Fix lcb dataset issue in examples dir#1349s-chundi wants to merge 1 commit intoNovaSky-AI:mainfrom
s-chundi wants to merge 1 commit intoNovaSky-AI:mainfrom
Conversation
Contributor
|
Warning Gemini is experiencing higher than usual traffic and was unable to create the review. Please try again in a few hours by commenting |
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request resolves a crash when loading large JSON datasets by switching to the more efficient Parquet format. The changes in lcb_dataset.py correctly replace pandas with datasets for this purpose, and run_lcb.sh is updated accordingly. I've included a suggestion to remove a redundant file creation, which will make the data processing script more efficient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #542
The original
deepcoder_train.jsonis a 5.2 GB JSON array. Whendatasets.load_dataset("json", ...)reads it, PyArrow's JSON reader sets a block_size based on the file size, but block_size is anint32_t— so any file over ~2 GB overflows and crashes withOverflowError: value too large to convert to int32_t.Changed lcb_dataset.py to output parquet files directly via
Dataset.from_list()instead of writing large JSON arrays. Updated data paths to reference the new.parquetfiles.Confirmed by training on the resulting parquet files