Skip to content

postgresqlPackages: housekeeping#390487

Merged
wolfgangwalther merged 72 commits intoNixOS:masterfrom
wolfgangwalther:postgresql-pkgs-updates
Mar 18, 2025
Merged

postgresqlPackages: housekeeping#390487
wolfgangwalther merged 72 commits intoNixOS:masterfrom
wolfgangwalther:postgresql-pkgs-updates

Conversation

@wolfgangwalther
Copy link
Copy Markdown
Contributor

@wolfgangwalther wolfgangwalther commented Mar 16, 2025

Some cleanup around postgresqlPackages:

  • started with some package updates,
  • went on to modernize all expressions,
  • and finished with some refactors.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@wolfgangwalther wolfgangwalther force-pushed the postgresql-pkgs-updates branch 3 times, most recently from 1dd5c1e to 14c7f28 Compare March 17, 2025 07:38
@github-actions github-actions Bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Mar 17, 2025
@wolfgangwalther wolfgangwalther force-pushed the postgresql-pkgs-updates branch from 14c7f28 to c6df809 Compare March 17, 2025 19:05
@ofborg ofborg Bot added the ofborg-internal-error Ofborg encountered an error label Mar 17, 2025
@wolfgangwalther
Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 390487


x86_64-linux

⏩ 4 packages marked as broken and skipped:
  • postgresql13JitPackages.citus
  • postgresql13Packages.citus
  • postgresql14JitPackages.citus
  • postgresql14Packages.citus
✅ 56 packages built:
  • postgresql13JitPackages.apache_datasketches
  • postgresql13JitPackages.pg-gvm
  • postgresql13JitPackages.pg_squeeze
  • postgresql13JitPackages.plr
  • postgresql13JitPackages.wal2json
  • postgresql13Packages.apache_datasketches
  • postgresql13Packages.pg-gvm
  • postgresql13Packages.pg_squeeze
  • postgresql13Packages.plr
  • postgresql13Packages.wal2json
  • postgresql14JitPackages.apache_datasketches
  • postgresql14JitPackages.pg-gvm
  • postgresql14JitPackages.pg_squeeze
  • postgresql14JitPackages.plr
  • postgresql14JitPackages.wal2json
  • postgresql14Packages.apache_datasketches
  • postgresql14Packages.pg-gvm
  • postgresql14Packages.pg_squeeze
  • postgresql14Packages.plr
  • postgresql14Packages.wal2json
  • postgresql15JitPackages.apache_datasketches
  • postgresql15JitPackages.citus
  • postgresql15JitPackages.pg-gvm
  • postgresql15JitPackages.pg_squeeze
  • postgresql15JitPackages.plr
  • postgresql15JitPackages.wal2json
  • postgresql15Packages.apache_datasketches
  • postgresql15Packages.citus
  • postgresql15Packages.pg-gvm
  • postgresql15Packages.pg_squeeze
  • postgresql15Packages.plr
  • postgresql15Packages.wal2json
  • postgresql16JitPackages.apache_datasketches
  • postgresql16JitPackages.citus
  • postgresql16JitPackages.pg-gvm
  • postgresql16JitPackages.pg_squeeze
  • postgresql16JitPackages.plr
  • postgresql16JitPackages.wal2json
  • postgresql16Packages.apache_datasketches
  • postgresql16Packages.citus
  • postgresql16Packages.pg-gvm
  • postgresql16Packages.pg_squeeze
  • postgresql16Packages.plr
  • postgresql16Packages.wal2json
  • postgresqlJitPackages.apache_datasketches (postgresql17JitPackages.apache_datasketches)
  • postgresqlJitPackages.citus (postgresql17JitPackages.citus)
  • postgresqlJitPackages.pg-gvm (postgresql17JitPackages.pg-gvm)
  • postgresqlJitPackages.pg_squeeze (postgresql17JitPackages.pg_squeeze)
  • postgresqlJitPackages.plr (postgresql17JitPackages.plr)
  • postgresqlJitPackages.wal2json (postgresql17JitPackages.wal2json)
  • postgresqlPackages.apache_datasketches (postgresql17Packages.apache_datasketches)
  • postgresqlPackages.citus (postgresql17Packages.citus)
  • postgresqlPackages.pg-gvm (postgresql17Packages.pg-gvm)
  • postgresqlPackages.pg_squeeze (postgresql17Packages.pg_squeeze)
  • postgresqlPackages.plr (postgresql17Packages.plr)
  • postgresqlPackages.wal2json (postgresql17Packages.wal2json)

aarch64-linux

⏩ 4 packages marked as broken and skipped:
  • postgresql13JitPackages.citus
  • postgresql13Packages.citus
  • postgresql14JitPackages.citus
  • postgresql14Packages.citus
✅ 56 packages built:
  • postgresql13JitPackages.apache_datasketches
  • postgresql13JitPackages.pg-gvm
  • postgresql13JitPackages.pg_squeeze
  • postgresql13JitPackages.plr
  • postgresql13JitPackages.wal2json
  • postgresql13Packages.apache_datasketches
  • postgresql13Packages.pg-gvm
  • postgresql13Packages.pg_squeeze
  • postgresql13Packages.plr
  • postgresql13Packages.wal2json
  • postgresql14JitPackages.apache_datasketches
  • postgresql14JitPackages.pg-gvm
  • postgresql14JitPackages.pg_squeeze
  • postgresql14JitPackages.plr
  • postgresql14JitPackages.wal2json
  • postgresql14Packages.apache_datasketches
  • postgresql14Packages.pg-gvm
  • postgresql14Packages.pg_squeeze
  • postgresql14Packages.plr
  • postgresql14Packages.wal2json
  • postgresql15JitPackages.apache_datasketches
  • postgresql15JitPackages.citus
  • postgresql15JitPackages.pg-gvm
  • postgresql15JitPackages.pg_squeeze
  • postgresql15JitPackages.plr
  • postgresql15JitPackages.wal2json
  • postgresql15Packages.apache_datasketches
  • postgresql15Packages.citus
  • postgresql15Packages.pg-gvm
  • postgresql15Packages.pg_squeeze
  • postgresql15Packages.plr
  • postgresql15Packages.wal2json
  • postgresql16JitPackages.apache_datasketches
  • postgresql16JitPackages.citus
  • postgresql16JitPackages.pg-gvm
  • postgresql16JitPackages.pg_squeeze
  • postgresql16JitPackages.plr
  • postgresql16JitPackages.wal2json
  • postgresql16Packages.apache_datasketches
  • postgresql16Packages.citus
  • postgresql16Packages.pg-gvm
  • postgresql16Packages.pg_squeeze
  • postgresql16Packages.plr
  • postgresql16Packages.wal2json
  • postgresqlJitPackages.apache_datasketches (postgresql17JitPackages.apache_datasketches)
  • postgresqlJitPackages.citus (postgresql17JitPackages.citus)
  • postgresqlJitPackages.pg-gvm (postgresql17JitPackages.pg-gvm)
  • postgresqlJitPackages.pg_squeeze (postgresql17JitPackages.pg_squeeze)
  • postgresqlJitPackages.plr (postgresql17JitPackages.plr)
  • postgresqlJitPackages.wal2json (postgresql17JitPackages.wal2json)
  • postgresqlPackages.apache_datasketches (postgresql17Packages.apache_datasketches)
  • postgresqlPackages.citus (postgresql17Packages.citus)
  • postgresqlPackages.pg-gvm (postgresql17Packages.pg-gvm)
  • postgresqlPackages.pg_squeeze (postgresql17Packages.pg_squeeze)
  • postgresqlPackages.plr (postgresql17Packages.plr)
  • postgresqlPackages.wal2json (postgresql17Packages.wal2json)

x86_64-darwin

⏩ 4 packages marked as broken and skipped:
  • postgresql13JitPackages.citus
  • postgresql13Packages.citus
  • postgresql14JitPackages.citus
  • postgresql14Packages.citus
✅ 46 packages built:
  • postgresql13JitPackages.apache_datasketches
  • postgresql13JitPackages.pg_squeeze
  • postgresql13JitPackages.plr
  • postgresql13JitPackages.wal2json
  • postgresql13Packages.apache_datasketches
  • postgresql13Packages.pg_squeeze
  • postgresql13Packages.plr
  • postgresql13Packages.wal2json
  • postgresql14JitPackages.apache_datasketches
  • postgresql14JitPackages.pg_squeeze
  • postgresql14JitPackages.plr
  • postgresql14JitPackages.wal2json
  • postgresql14Packages.apache_datasketches
  • postgresql14Packages.pg_squeeze
  • postgresql14Packages.plr
  • postgresql14Packages.wal2json
  • postgresql15JitPackages.apache_datasketches
  • postgresql15JitPackages.citus
  • postgresql15JitPackages.pg_squeeze
  • postgresql15JitPackages.plr
  • postgresql15JitPackages.wal2json
  • postgresql15Packages.apache_datasketches
  • postgresql15Packages.citus
  • postgresql15Packages.pg_squeeze
  • postgresql15Packages.plr
  • postgresql15Packages.wal2json
  • postgresql16JitPackages.apache_datasketches
  • postgresql16JitPackages.citus
  • postgresql16JitPackages.pg_squeeze
  • postgresql16JitPackages.plr
  • postgresql16JitPackages.wal2json
  • postgresql16Packages.apache_datasketches
  • postgresql16Packages.citus
  • postgresql16Packages.pg_squeeze
  • postgresql16Packages.plr
  • postgresql16Packages.wal2json
  • postgresqlJitPackages.apache_datasketches (postgresql17JitPackages.apache_datasketches)
  • postgresqlJitPackages.citus (postgresql17JitPackages.citus)
  • postgresqlJitPackages.pg_squeeze (postgresql17JitPackages.pg_squeeze)
  • postgresqlJitPackages.plr (postgresql17JitPackages.plr)
  • postgresqlJitPackages.wal2json (postgresql17JitPackages.wal2json)
  • postgresqlPackages.apache_datasketches (postgresql17Packages.apache_datasketches)
  • postgresqlPackages.citus (postgresql17Packages.citus)
  • postgresqlPackages.pg_squeeze (postgresql17Packages.pg_squeeze)
  • postgresqlPackages.plr (postgresql17Packages.plr)
  • postgresqlPackages.wal2json (postgresql17Packages.wal2json)

aarch64-darwin

⏩ 4 packages marked as broken and skipped:
  • postgresql13JitPackages.citus
  • postgresql13Packages.citus
  • postgresql14JitPackages.citus
  • postgresql14Packages.citus
❌ 10 packages failed to build:
  • postgresql15JitPackages.apache_datasketches
  • postgresql15JitPackages.citus
  • postgresql15JitPackages.pg_squeeze
  • postgresql15JitPackages.plr
  • postgresql15JitPackages.wal2json
  • postgresql16Packages.apache_datasketches
  • postgresql16Packages.citus
  • postgresql16Packages.pg_squeeze
  • postgresql16Packages.plr
  • postgresql16Packages.wal2json
✅ 36 packages built:
  • postgresql13JitPackages.apache_datasketches
  • postgresql13JitPackages.pg_squeeze
  • postgresql13JitPackages.plr
  • postgresql13JitPackages.wal2json
  • postgresql13Packages.apache_datasketches
  • postgresql13Packages.pg_squeeze
  • postgresql13Packages.plr
  • postgresql13Packages.wal2json
  • postgresql14JitPackages.apache_datasketches
  • postgresql14JitPackages.pg_squeeze
  • postgresql14JitPackages.plr
  • postgresql14JitPackages.wal2json
  • postgresql14Packages.apache_datasketches
  • postgresql14Packages.pg_squeeze
  • postgresql14Packages.plr
  • postgresql14Packages.wal2json
  • postgresql15Packages.apache_datasketches
  • postgresql15Packages.citus
  • postgresql15Packages.pg_squeeze
  • postgresql15Packages.plr
  • postgresql15Packages.wal2json
  • postgresql16JitPackages.apache_datasketches
  • postgresql16JitPackages.citus
  • postgresql16JitPackages.pg_squeeze
  • postgresql16JitPackages.plr
  • postgresql16JitPackages.wal2json
  • postgresqlJitPackages.apache_datasketches (postgresql17JitPackages.apache_datasketches)
  • postgresqlJitPackages.citus (postgresql17JitPackages.citus)
  • postgresqlJitPackages.pg_squeeze (postgresql17JitPackages.pg_squeeze)
  • postgresqlJitPackages.plr (postgresql17JitPackages.plr)
  • postgresqlJitPackages.wal2json (postgresql17JitPackages.wal2json)
  • postgresqlPackages.apache_datasketches (postgresql17Packages.apache_datasketches)
  • postgresqlPackages.citus (postgresql17Packages.citus)
  • postgresqlPackages.pg_squeeze (postgresql17Packages.pg_squeeze)
  • postgresqlPackages.plr (postgresql17Packages.plr)
  • postgresqlPackages.wal2json (postgresql17Packages.wal2json)

The aarch64-darwin failures are because postgresql_15 and postgresql_16 fail to build there right now with this:

error: build of '/nix/store/3czq1a67pbpkkmh969b6mwjbl6fzal7z-postgresql-16.8.drv' on 'ssh-ng://wolfgangwalther@darwin-build-box.nix-community.org' failed: derivation contains an illegal reference specifier 'man'
error: build of '/nix/store/swkwajhlx2cvydv3fxpmb9pn287wadc5-postgresql-jit-15.12.drv' on 'ssh-ng://wolfgangwalther@darwin-build-box.nix-community.org' failed: derivation contains an illegal reference specifier 'doc'

IIRC, that's the nix-bug we hit a while ago. @Ma27 were you able to fix that, btw?

@wolfgangwalther wolfgangwalther marked this pull request as ready for review March 17, 2025 19:44
Comment thread pkgs/servers/sql/postgresql/ext/apache_datasketches.nix Outdated
@Ma27
Copy link
Copy Markdown
Member

Ma27 commented Mar 18, 2025

IIRC, that's the nix-bug we hit a while ago. @Ma27 were you able to fix that, btw?

It should be fixed in Lix, no idea about the state in Nix.

No need to manually put them in the default.nix file anymore.
…dExtension

This is for consistency with postgresqlTestExtension and
postgresqlTestHook. Everything that is passed via postgresql's
generic.nix "packages scope" now is prefixed with "postgresql".
The build on darwin was broken for v16 and v17 only. This was fixed
upstream a while ago, but somehow the fix has not been released, yet.
@wolfgangwalther
Copy link
Copy Markdown
Contributor Author

It should be fixed in Lix, no idea about the state in Nix.

Ok, thanks. Since the community-builder is running Nix, it makes sense that it appears there.

@wolfgangwalther wolfgangwalther force-pushed the postgresql-pkgs-updates branch from c6df809 to 65cee89 Compare March 18, 2025 17:18
@ofborg ofborg Bot removed the ofborg-internal-error Ofborg encountered an error label Mar 18, 2025
@wolfgangwalther wolfgangwalther merged commit 0fbffad into NixOS:master Mar 18, 2025
23 checks passed
@wolfgangwalther wolfgangwalther deleted the postgresql-pkgs-updates branch March 18, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants