Skip to content

wayqt: init at 0.2.0#263965

Merged
Atemu merged 1 commit intoNixOS:masterfrom
wineee:wayqt
Feb 6, 2024
Merged

wayqt: init at 0.2.0#263965
Atemu merged 1 commit intoNixOS:masterfrom
wineee:wayqt

Conversation

@wineee
Copy link
Copy Markdown
Member

@wineee wineee commented Oct 28, 2023

Description of changes

https://gitlab.com/desktop-frameworks/wayqt

dependencies for qtgreet and paper desktop (#195371 and #218112

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@wineee wineee force-pushed the wayqt branch 2 times, most recently from 18b1aab to de3b480 Compare October 29, 2023 14:58
@ofborg ofborg Bot added the 8.has: package (new) This PR adds a new package label Oct 29, 2023
@ofborg ofborg Bot requested a review from Atemu October 29, 2023 15:23
@ofborg ofborg Bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 29, 2023
@marsam
Copy link
Copy Markdown
Contributor

marsam commented Feb 1, 2024

LGTM, please resolve the conflicts

Atemu
Atemu previously requested changes Feb 1, 2024
Comment thread pkgs/development/libraries/wayqt/default.nix Outdated
@wineee wineee changed the title wayqt: init at 0.1.99 wayqt: init at 0.2.0 Feb 2, 2024
@ofborg ofborg Bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Feb 2, 2024
@Atemu
Copy link
Copy Markdown
Member

Atemu commented Feb 2, 2024

Please squash.

Comment thread pkgs/top-level/qt6-packages.nix
@Atemu Atemu dismissed their stale review February 6, 2024 11:58

Wrong.

@Atemu Atemu merged commit 8d9b52d into NixOS:master Feb 6, 2024
@wineee wineee deleted the wayqt branch February 6, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants