Skip to content

Aws sdk cpp disable flaky test#135928

Merged
happysalada merged 1 commit intoNixOS:staging-nextfrom
happysalada:aws_sdk_cpp_disable_flaky_test
Aug 28, 2021
Merged

Aws sdk cpp disable flaky test#135928
happysalada merged 1 commit intoNixOS:staging-nextfrom
happysalada:aws_sdk_cpp_disable_flaky_test

Conversation

@happysalada
Copy link
Copy Markdown
Contributor

@happysalada happysalada commented Aug 27, 2021

Motivation for this change

The test for aws-sdk-cpp is flaky https://hydra.nixos.org/build/150722293/nixlog/1
removing the file completely is a little bit of an overkill, but it's certainly better than wasting time on a flaky test.
I tried building locally and I did not get a failure.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@happysalada happysalada mentioned this pull request Aug 27, 2021
Merged
@ofborg ofborg Bot requested a review from edolstra August 27, 2021 15:56
@ofborg ofborg Bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 27, 2021
@r-burns
Copy link
Copy Markdown
Contributor

r-burns commented Aug 27, 2021 •
edited
Loading

Disabling the test looks good to me. I'm -1 on the auto-formatting prior to settling on an approach in NixOS/rfcs#101.

@happysalada
Copy link
Copy Markdown
Contributor Author

happysalada commented Aug 28, 2021

cool, I did it in a separate commit, let me revert.

@happysalada happysalada force-pushed the aws_sdk_cpp_disable_flaky_test branch from 7ac84f2 to b2621bd Compare August 28, 2021 00:45
@happysalada
Copy link
Copy Markdown
Contributor Author

happysalada commented Aug 28, 2021

Removed, let me know if that works for you.

r-burns
r-burns approved these changes Aug 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@happysalada happysalada merged commit c65ec0c into NixOS:staging-next Aug 28, 2021
@happysalada happysalada deleted the aws_sdk_cpp_disable_flaky_test branch August 28, 2021 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r-burns r-burns r-burns approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@happysalada @r-burns