This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix(remove user): handles user removal failures more gracefully#6196
Merged
fix(remove user): handles user removal failures more gracefully#6196
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves error handling for user removal operations in the Slack plugin by gracefully handling cases where users are not found in the Slack workspace. The changes ensure that user removal failures don't cause exceptions and provide better logging and user feedback.
- Enhanced the
remove_usermethod in the Slack plugin with comprehensive error handling for user lookup failures - Added graceful error handling in case and incident interactive flows when looking up users by email
- Moved try-catch blocks to more appropriate locations in participant removal flows
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/dispatch/plugins/dispatch_slack/plugin.py | Enhanced remove_user method with better error handling, logging, and documentation |
| src/dispatch/plugins/dispatch_slack/case/interactive.py | Added error handling for user lookup failures in engage and edit functions |
| src/dispatch/incident/flows.py | Moved try-catch block to wrap the actual remove_user call instead of plugin lookup |
| src/dispatch/case/flows.py | Moved try-catch block to wrap the actual remove_user call instead of plugin lookup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Marc Vilanova <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Marc Vilanova <[email protected]>
nathanmyee
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.