Skip to content

Do not copy tns_modules from app dir#858

Merged
rosen-vladimirov merged 1 commit into
masterfrom
vladimirov/fix-tns_modules-copying
Sep 3, 2015
Merged

Do not copy tns_modules from app dir#858
rosen-vladimirov merged 1 commit into
masterfrom
vladimirov/fix-tns_modules-copying

Conversation

@rosen-vladimirov
Copy link
Copy Markdown
Contributor

In case there's tns_modules in app directory, they are copied on each prepare. Skip tns_modules as they are now installed as npm dependency. Warn the user that the tns_modules from app will not be used.
Fixes #854

In case there's tns_modules in app directory, they are copied on each prepare. Skip tns_modules as they are now installed as npm dependency. Warn the user that the tns_modules from app will not be used.
Fixes #854
@rosen-vladimirov rosen-vladimirov self-assigned this Sep 2, 2015
@rosen-vladimirov rosen-vladimirov added this to the 1.3.0 milestone Sep 2, 2015
@ns-bot
Copy link
Copy Markdown

ns-bot commented Sep 2, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have a constant for tns_modules

@Fatme
Copy link
Copy Markdown
Contributor

Fatme commented Sep 3, 2015

👍

rosen-vladimirov added a commit that referenced this pull request Sep 3, 2015
…copying

Do not copy tns_modules from app dir
@rosen-vladimirov rosen-vladimirov merged commit e1b165c into master Sep 3, 2015
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/fix-tns_modules-copying branch September 3, 2015 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants