Work correctly if iOS runtime version is lower than 1.3#834
Merged
Conversation
|
❌ |
561692e to
52a2f50
Compare
Contributor
There was a problem hiding this comment.
You may use future.fromResult here
|
✅ |
Contributor
There was a problem hiding this comment.
Both return statements build the same path - is this expected?
Contributor
Author
There was a problem hiding this comment.
The paths are different - path.join(this.platformData.projectRoot, this.$projectData.projectName, "Resources", "icons"); and path.join(this.platformData.projectRoot, this.$projectData.projectName, "Resources");
Contributor
There was a problem hiding this comment.
Oh dear, the last part ("icons") went on another line on my monitor and I missed it completely. I am so sorry.
Contributor
|
tests are failing: |
52a2f50 to
8829fda
Compare
|
❌ |
Fix unit tests
8829fda to
3488c61
Compare
|
✅ |
Contributor
|
👍 |
rosen-vladimirov
added a commit
that referenced
this pull request
Sep 2, 2015
…os-runtme Work correctly if iOS runtime version is lower than 1.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #832