Cocoapods support#769
Conversation
|
✅ |
There was a problem hiding this comment.
Shouldn't we display the error as well? For example CocoaPods might be installed but the command pod install to fail for some reason?
There was a problem hiding this comment.
This check must also be introduced in doctor command.
|
Consider adding checks for CocoaPods in the |
There was a problem hiding this comment.
Consider adding a comment in the general pod file mentioning that the code is from this given file.
|
Adding some unit tests for this functionality will be great. 👮 |
|
✅ |
There was a problem hiding this comment.
I guess this change is leftover from debugging - but it currently breaks our test suite.
|
✅ |
There was a problem hiding this comment.
The message on my machine is ERROR: Can't find ruby library file or shared library cocoapods. We must find another way to check for existence. Checking the exit code looks promising.
There was a problem hiding this comment.
We discussed the issue in person and we decided that the code is correct.
|
✅ |
|
✅ |
|
✅ |
No description provided.