Skip to content

Open web inspector frontend in a standalone application instead of Safari#604

Merged
KristinaKoeva merged 1 commit into
masterfrom
KristinaKoeva/DebuggingFix
Jul 3, 2015
Merged

Open web inspector frontend in a standalone application instead of Safari#604
KristinaKoeva merged 1 commit into
masterfrom
KristinaKoeva/DebuggingFix

Conversation

@KristinaKoeva
Copy link
Copy Markdown
Contributor

The update of JavaScriptCore that we use in the iOS bridge goes with an updated web inspector frontend. The updated frontend is not rendered properly in latest Safari, so as a workaround open an application that would be distributed with the iOS bridge package

Related to NativeScript/ios-jsc#201

@ns-bot
Copy link
Copy Markdown

ns-bot commented Jun 30, 2015

Can one of the admins verify this patch?

1 similar comment
@ns-bot
Copy link
Copy Markdown

ns-bot commented Jun 30, 2015

Can one of the admins verify this patch?

@Fatme Fatme added this to the 1.2.0 milestone Jun 30, 2015
@Fatme
Copy link
Copy Markdown
Contributor

Fatme commented Jun 30, 2015

👍

Comment thread lib/services/ios-debug-service.ts Outdated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to use let instead of var here.

…lize the updated web inspector frontend. So open the application instead of Safari, because Safari is not able to render the frontend properly
@KristinaKoeva KristinaKoeva force-pushed the KristinaKoeva/DebuggingFix branch from c363ccf to 29a7a97 Compare July 2, 2015 11:06
@KristinaKoeva
Copy link
Copy Markdown
Contributor Author

ping @ligaz @teobugslayer

@ligaz
Copy link
Copy Markdown

ligaz commented Jul 2, 2015

👍

1 similar comment
@teobugslayer
Copy link
Copy Markdown
Contributor

👍

KristinaKoeva added a commit that referenced this pull request Jul 3, 2015
Open web inspector frontend in a standalone application instead of Safari
@KristinaKoeva KristinaKoeva merged commit ac6e475 into master Jul 3, 2015
@KristinaKoeva KristinaKoeva deleted the KristinaKoeva/DebuggingFix branch July 3, 2015 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants