Skip to content

fix: project properties are not tracked on every analytics hit#4194

Merged
rosen-vladimirov merged 1 commit intomasterfrom
vladimirov/analytics-project-dir
Dec 4, 2018
Merged

fix: project properties are not tracked on every analytics hit#4194
rosen-vladimirov merged 1 commit intomasterfrom
vladimirov/analytics-project-dir

Conversation

@rosen-vladimirov
Copy link
Contributor

@rosen-vladimirov rosen-vladimirov commented Dec 3, 2018

Currently projectType and isShared properties are tracked only when we send events to Google Analytics and when the caller sends the projectDir to the method. In fact we need to track them(based on the projectDir) for every hit in Google Analytics.
To achieve this, use the projectHelper, which tries to determine the projectDir. Track the projectType on every page and event send to Google Analytics.

PR Checklist

What is the current behavior?

When tracking pageviews in Google Analytics, the respective projectType is not tracked.
Also for some of the events, the projectType is not tracked.

What is the new behavior?

ProjecType is tracked for every hit (when action is executed inside project dir or with --path)

@rosen-vladimirov rosen-vladimirov added this to the 5.1.0 milestone Dec 3, 2018
@rosen-vladimirov rosen-vladimirov self-assigned this Dec 3, 2018
@rosen-vladimirov rosen-vladimirov force-pushed the vladimirov/analytics-project-dir branch from 88e2b10 to 237bfff Compare December 3, 2018 15:43
@rosen-vladimirov rosen-vladimirov changed the title fix: projectType is not tracked on every analytics hit fix: project properties are not tracked on every analytics hit Dec 3, 2018
Currently projectType and isShared properties are tracked only when we send events to Google Analytics and when the caller sends the projectDir to the method. In fact we need to track them(based on the projectDir) for every hit in Google Analytics.
To achieve this, use the projectHelper, which tries to determine the projectDir. Track the projectType on every page and event send to Google Analytics.
@rosen-vladimirov rosen-vladimirov force-pushed the vladimirov/analytics-project-dir branch from 237bfff to 8ab8ed3 Compare December 3, 2018 20:05
@rosen-vladimirov
Copy link
Contributor Author

run ci

1 similar comment
@rosen-vladimirov
Copy link
Contributor Author

run ci

@rosen-vladimirov rosen-vladimirov merged commit 51fc9c5 into master Dec 4, 2018
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/analytics-project-dir branch December 4, 2018 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants