Skip to content

feat(commands): Introduce postCommandAction#3501

Merged
rosen-vladimirov merged 1 commit into
releasefrom
vladimirov/post-command-actions
Mar 28, 2018
Merged

feat(commands): Introduce postCommandAction#3501
rosen-vladimirov merged 1 commit into
releasefrom
vladimirov/post-command-actions

Conversation

@rosen-vladimirov
Copy link
Copy Markdown
Contributor

Introduce postCommandAction that is executed when the command succeeds.
Use the action to print additional information to user how to continue after command is finished.
Show some information on successful postinstall - instruct the users how to use local builds, cloud builds and playground.

@rosen-vladimirov rosen-vladimirov added this to the 4.0.0 milestone Mar 26, 2018
@rosen-vladimirov rosen-vladimirov self-assigned this Mar 26, 2018
@rosen-vladimirov rosen-vladimirov requested a review from Fatme March 26, 2018 22:41
Comment thread lib/commands/post-install.ts Outdated
$doctorService: IDoctorService,
$analyticsService: IAnalyticsService,
$logger: ILogger) {
protected $logger: ILogger) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$protected is not needed

@rosen-vladimirov rosen-vladimirov force-pushed the vladimirov/post-command-actions branch from f5d33c7 to 8176817 Compare March 28, 2018 07:38
Introduce postCommandAction that is executed when the command succeeds.
Use the action to print additional information to user how to continue after command is finished.
Show some information on successful postinstall - instruct the users how to use local builds, cloud builds and playground.
@rosen-vladimirov rosen-vladimirov force-pushed the vladimirov/post-command-actions branch from 8176817 to f9ef10b Compare March 28, 2018 09:45
@rosen-vladimirov rosen-vladimirov changed the title feat(commands) Introduce postCommandAction feat(commands): Introduce postCommandAction Mar 28, 2018
@rosen-vladimirov rosen-vladimirov merged commit 37c2576 into release Mar 28, 2018
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/post-command-actions branch March 28, 2018 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants