fix(tooling): wait for emulator before running adb commands#912
Merged
Conversation
|
💔 |
caddd6c to
65ac5c3
Compare
a3888da to
f26c787
Compare
|
💔 |
1 similar comment
|
💔 |
|
run ci |
|
💔 |
|
run ci |
|
💔 |
|
run ci |
|
💚 |
|
run ci |
1 similar comment
|
run ci |
Contributor
Author
|
run CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem
We try to run adb commands before the device is ready to receive them. Devices/Emulators may pass through different states like:
device is offlineor the bootup animation is stillrunning.solution
Make the test tooling wait for the emulator to be fully operation before running any
adbcommands or even installing the app to prevent running commands too early.