write output from C tests to temporary directory#1126
Merged
stevengj merged 4 commits intoNanoComp:masterfrom Feb 18, 2020
Merged
write output from C tests to temporary directory#1126stevengj merged 4 commits intoNanoComp:masterfrom
stevengj merged 4 commits intoNanoComp:masterfrom
Conversation
stevengj
reviewed
Feb 15, 2020
stevengj
reviewed
Feb 18, 2020
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
* write output from C tests to temporary directory * fix * replace rmdir with POSIX ntfw * put am_master before nftw rather than delete_directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #1121 and #1122, the output from the C test suite is written to a temporary directory rather than a subdirectory. Of the 19 tests only one (tests/h5test.cpp) actually produces HDF5 output files. For some reason, six of the other tests create an output directory even though no files were being written. This has been corrected.
Finally, following the discussion earlier today, Tutorials/Eigenmode Source/Index-Guided Modes in a Ridge Waveguide has been updated to explicitly mention that the eigenmode source does not need to span the entire length of the cell.
(All tests pass when NanoComp/libctl#53 is excluded.)