fix(api): Address misclassification of NVOS data interface IPs as BMC IPs

[nvlitagaki]

Previously our search IP address logic mistakenly categorized all statically allocated machine interface addresses as static BMC IPs. Now it looks to the interface type as well as the allocation type to categorize the interface.

Additionally, if the response to an IP address search is associated with a switch, the CLI now prints the switch.

Related issues

Internal issue

Type of Change

• Change - Changes in existing functionality
• Fix - Bug fixes

Breaking Changes

• This PR contains breaking changes

Testing

• Unit tests added/updated
• Manual testing performed

Additional Notes

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1accfcff-e9ed-4e35-ac92-081c227c7a79

📥 Commits

Reviewing files that changed from the base of the PR and between 549ea90 and e681a99.

📒 Files selected for processing (1)

• crates/api-core/src/handlers/finder.rs

🚧 Files skipped from review as they are similar to previous changes (1)

• crates/api-core/src/handlers/finder.rs

---

Summary by CodeRabbit

• Bug Fixes

  • Improved IP finder classification by identifying static BMC IPs only on BMC interfaces, preventing static data/NVOS IPs from being misclassified.
  • Enhanced finder results with clearer switch association details and more accurate human-readable messages.

• Tests

  • Expanded integration coverage for static BMC, machine, switch, and data IP classification and messaging.

Walkthrough

Finder address classification now uses interface type and switch metadata from database lookups. Static BMC results require a BMC interface. Machine and switch addresses receive distinct messages. Tests validate classifications and message content.

Changes

Finder classification

Layer / File(s)	Summary
Interface metadata lookup crates/api-db/src/machine_interface_address.rs	find_by_address now returns switch_id and interface_type through MachineInterfaceSearchResult.
Interface-aware finder logic crates/api-core/src/handlers/finder.rs	Static BMC classification requires interface_type == Bmc. Machine-address messages distinguish machine and switch associations.
Classification tests crates/api-core/src/handlers/finder.rs, crates/api-core/src/tests/finder.rs	Tests validate BMC-only classification, static BMC messaging, and non-BMC static data address results.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Finder
  participant MachineInterfaceSearch
  participant IpAddressMatch
  Finder->>MachineInterfaceSearch: find_by_address
  MachineInterfaceSearch-->>Finder: interface_type, switch_id, allocation metadata
  Finder->>IpAddressMatch: classify address
  Finder->>IpAddressMatch: format classification message

Loading

Possibly related PRs

• NVIDIA/infra-controller#4283: Adds BMC interface classification and static-assignment fallback semantics used by this finder logic.

Suggested labels: rest-api

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the API fix for misclassifying NVOS data interface IPs as BMC IPs.
Description check	✅ Passed	The description accurately covers the classification fix, switch output change, and related testing.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[nvlitagaki]

/ok to test b921d16

[nvlitagaki]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[github-actions]

🌿 Preview your docs: https://nvidia-preview-pull-request-4395.docs.buildwithfern.com/infra-controller

[coderabbitai]

🧹 Nitpick comments (1)

crates/api-core/src/handlers/finder.rs (1)

515-579: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Use carbide-test-support table-driven helpers instead of a manual for-loop.

machine_interface_address_is_static_bmc is a total function (segment_name, allocation_type, interface_type) → bool, which fits value_scenarios! / check_values per the repository's testing conventions rather than a hand-rolled for loop with assert_eq!.

As per coding guidelines, "Use the carbide-test-support table-driven testing helpers for functions mapping inputs to outputs or errors; use scenarios! for Result, value_scenarios! for total operations, and direct check helpers when macros obscure intent." Also, "Prefer table-driven tests; for Rust, use grouped carbide-test-support scenarios (scenarios! / value_scenarios!) or explicit cases (check_cases / check_values) to cover input variants."

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/api-core/src/handlers/finder.rs` around lines 515 - 579, The test
static_bmc_classification_requires_bmc_interface_type currently uses a manual
loop and assertions for a total function. Replace the loop with the repository’s
carbide-test-support table-driven helper, using value_scenarios! with
check_values or the applicable direct helper, while preserving all existing
input combinations, expected booleans, and case labels.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@crates/api-core/src/handlers/finder.rs`:
- Around line 515-579: The test
static_bmc_classification_requires_bmc_interface_type currently uses a manual
loop and assertions for a total function. Replace the loop with the repository’s
carbide-test-support table-driven helper, using value_scenarios! with
check_values or the applicable direct helper, while preserving all existing
input combinations, expected booleans, and case labels.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 03620869-a42a-4bd4-9143-b618bba7a0de

📥 Commits

Reviewing files that changed from the base of the PR and between 1d2f5e5 and b921d16.

📒 Files selected for processing (3)

• crates/api-core/src/handlers/finder.rs
• crates/api-core/src/tests/finder.rs
• crates/api-db/src/machine_interface_address.rs