Require openssl so that conda verson is found before system lib#1084
Require openssl so that conda verson is found before system lib#1084hlinsen wants to merge 5 commits intoNVIDIA:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds conditional OpenSSL resolution to the CMake build: if Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@cpp/CMakeLists.txt`:
- Around line 297-299: The CMake logic wrongly checks OPENSSL_FOUND but forces
config-mode with find_package(OpenSSL CONFIG REQUIRED), which breaks on systems
without OpenSSLConfig.cmake; change to a target-based config-first fallback:
first try find_package(OpenSSL CONFIG QUIET) and check for the imported target
OpenSSL::SSL (or OpenSSL::Crypto/OpenSSL::SSL), and if that target is not
present then fall back to find_package(OpenSSL MODULE REQUIRED) (or
find_package(OpenSSL REQUIRED) in module mode) so both config and module
discovery are supported; update the guard that currently references
OPENSSL_FOUND to instead test the presence of the OpenSSL::SSL target and only
call the module-mode find_package when the config-mode target is absent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c9acaaff-128e-4ddb-bfb5-13581e6f98d9
📒 Files selected for processing (1)
cpp/CMakeLists.txt
|
/ok to test 1c78f98 |
Before this PR the system lib of openssl was picked causing potential GLIBC version mismatches on certain machines
-- Found OpenSSL: /usr/lib/x86_64-linux-gnu/libcrypto.so (found version "3.0.13")With this PR we explicitly require openssl which forces Cmake to look for the conda path first. This
fixes unexpected compile errors.