[cuda_pathfinder] Add CUDA 12 support to cuda-pathfinder pixi environments and removing build-variants #1365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Collaborator
Author
|
/ok to test 9909fe2 |
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
/ok to test 368793e |
cpcloud
requested changes
Dec 12, 2025
Contributor
cpcloud
left a comment
There was a problem hiding this comment.
Nothing major, but we should probably put a lower bound on the Python version.
cpcloud
reviewed
Dec 12, 2025
cuda_pathfinder/pixi.toml
Outdated
Comment on lines
45
to
50
| [package.run-dependencies] | ||
| python = "*" | ||
| python = ">=3.10" | ||
| setuptools = ">=64" | ||
|
|
||
| [package.run-dependencies] | ||
| python = ">=3.10" |
Contributor
There was a problem hiding this comment.
These are duplicated, which is a bug. I'll add a suggestion here to fix it.
cpcloud
reviewed
Dec 12, 2025
cpcloud
approved these changes
Dec 12, 2025
kkraus14
approved these changes
Dec 12, 2025
Collaborator
|
/ok to test |
Contributor
@kkraus14, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
Collaborator
|
/ok to test aa681fd |
|
rwgk
added a commit
to rwgk/cuda-python
that referenced
this pull request
Dec 15, 2025
Merged latest changes from main including: - Added size property to StridedMemoryView (NVIDIA#1363) - NVML bindings updates (NVIDIA#1360) - cuda_pathfinder pixi configuration (NVIDIA#1365, NVIDIA#1361) All changes merged cleanly with no conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cu12pixi environment for CUDA 12 testingnoarch = "python"in package configuration