Make pedantic warnings opt-in in ci/build_X scripts#8218
Open
alliepiper wants to merge 2 commits intoNVIDIA:mainfrom
Open
Make pedantic warnings opt-in in ci/build_X scripts#8218alliepiper wants to merge 2 commits intoNVIDIA:mainfrom
alliepiper wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
Add CCCL_ENABLE_PRAGMA_SYSTEM_HEADER CMake option and --pedantic flag to ci/build_common.sh. Local builds now default to warnings suppressed and werror off. CI (GITHUB_ACTIONS) auto-enables pedantic mode. Direct cmake preset invocations retain existing defaults (werror on, system header pragma off). Lit test plumbing propagates the setting to Python config. Fixes NVIDIA#8217
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
pre-commit.ci autofix |
Contributor
Contributor
Author
|
/ok to test 2aef78b |
Contributor
🥳 CI Workflow Results🟩 Finished in 2h 52m: Pass: 100%/445 | Total: 13d 15h | Max: 2h 41m | Hits: 82%/514771See results here. |
bernhardmgruber
approved these changes
Mar 31, 2026
miscco
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CCCL_ENABLE_PRAGMA_SYSTEM_HEADER CMake option and --pedantic flag to ci/build_common.sh. Local builds now default to warnings suppressed and werror off. CI (GITHUB_ACTIONS) auto-enables pedantic mode. Direct cmake preset invocations retain existing defaults (werror on, system header pragma off). Lit test plumbing propagates the setting to Python config.
Fixes #8217