Guard CUDA probe when CUDA_HOME is unset#2008
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_cuda_bare_metal_version(CUDA_HOME)call insetup.pynvccduring metadata generation or Python-only installs whenCUDA_HOMEis unsetWhy
The repo still documents a Python-only install path, but
setup.pyalways probes the CUDA toolkit version at import time. That makes metadata generation fail before any CUDA extension was requested.This follows the same intent as #1499, which guarded one
CUDA_HOMEpath earlier insetup.py, but leaves the later unconditional probe untouched. It also matches the still-open no-CUDA build report in #1498 and the metadata-generation failure reported in #1702.Validation
python3 -m py_compile setup.py