[https://nvbugs/6541322][fix] Remove stale waiver for TestQwen3NextInstruct::test_bf16_4gpu[dep4] - #17150
Open
trtllm-agent wants to merge 1 commit into
Open
[https://nvbugs/6541322][fix] Remove stale waiver for TestQwen3NextInstruct::test_bf16_4gpu[dep4]#17150trtllm-agent wants to merge 1 commit into
trtllm-agent wants to merge 1 commit into
Conversation
The V2 Mamba state pool ValueError was fixed by 7f7dccf (KVCacheManagerV2 C++ translation, NVIDIA#14047), which added an SSM min-slot floor in _build_cache_config using the same expression as the live/dummy-slot check it guards, so the pool can no longer be sized below that floor. Remove the now-stale waiver for test_bf16_4gpu[dep4]. The sibling test_nvfp4[tp1_block_reuse-cutlass] waiver is left in place: it has an independent root cause tracked separately under nvbugs/6535767. Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThe change removes the skip entry for Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
1 task
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_num_requests; that floor fix has since landed in HEAD via commit 7f7dccf, so the failing code path no longer exists. The waiver entry for this test therefore outlived the defect it was tracking.nvidia-smi, leaving 53 MB free at a cublas allocation), so no product change was warranted. The change is waiver-only: drop thedep4SKIP line so the test runs again in CI, while leaving the siblingtp1_block_reuse-cutlasswaiver under the same bug in place since it was not shown to be fixed.Test plan
Links
Dev Engineer Review
dep4waiver forTestQwen3NextInstruct::test_bf16_4gpu[dep4].tp1_block_reuse-cutlasswaiver remains unchanged.QA Engineer Review
tests/integration/test_lists/waives.txt.