[None][fix] Update VisualGen test CODEOWNERS by yibinl-nvidia · Pull Request #16848 · NVIDIA/TensorRT-LLM

yibinl-nvidia · 2026-07-24T20:16:53Z

Dev Engineer Review

Updated .github/CODEOWNERS to remove the prior file-specific VisualGen ownership rule for tests/integration/defs/examples/test_visual_gen.py.
Added a new ownership rule assigning tests/integration/defs/examples/visual_gen to @NVIDIA/trt-llm-torch-visual-gen-devs.
Change is limited to CODEOWNERS configuration; no code/API/test behavior, performance, or scope beyond ownership metadata is impacted.

QA Engineer Review

No test changes.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

yibinl-nvidia · 2026-07-24T20:17:08Z

/bot run

coderabbitai · 2026-07-24T20:18:22Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d070a313-cf8a-4f1c-bb5b-0a881d545655

📥 Commits

Reviewing files that changed from the base of the PR and between 5e45658 and 3c73d00.

📒 Files selected for processing (1)

.github/CODEOWNERS

Walkthrough

The CODEOWNERS rule for the VisualGen integration example test file is replaced with a directory-level rule covering tests/integration/defs/examples/visual_gen.

Changes

VisualGen ownership

Layer / File(s)	Summary
Update VisualGen directory ownership `.github/CODEOWNERS`	Replaces the single-file ownership rule with directory-level ownership for the VisualGen integration definitions.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: emmaqiaoch, mlefeb01

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is mostly placeholder text and does not explain the change or list any test coverage.	Add a short issue/solution summary and fill in Test Coverage with the relevant checks or state none were run.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title follows the required [ticket][type] summary format and matches the CODEOWNERS update.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

tensorrt-cicd · 2026-07-24T20:23:17Z

PR_Github #61635 [ run ] triggered by Bot. Commit: 5e45658 Link to invocation

tensorrt-cicd · 2026-07-24T22:36:18Z

PR_Github #61635 [ run ] completed with state SUCCESS. Commit: 5e45658
/LLM/main/L0_MergeRequest_PR pipeline #49842 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

yibinl-nvidia · 2026-07-27T03:08:32Z

/bot run

Signed-off-by: Yibin Li <109242046+yibinl-nvidia@users.noreply.github.com>

tensorrt-cicd · 2026-07-27T03:14:51Z

PR_Github #61789 [ run ] triggered by Bot. Commit: 3c73d00 Link to invocation

tensorrt-cicd · 2026-07-27T06:37:09Z

PR_Github #61789 [ run ] completed with state SUCCESS. Commit: 3c73d00
/LLM/main/L0_MergeRequest_PR pipeline #49987 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

yibinl-nvidia · 2026-07-27T16:35:19Z

/bot run

tensorrt-cicd · 2026-07-27T16:42:50Z

PR_Github #61943 [ run ] triggered by Bot. Commit: 3c73d00 Link to invocation

tburt-nv · 2026-07-27T18:30:52Z

 /tensorrt_llm/media @NVIDIA/trt-llm-torch-visual-gen-devs
 /tensorrt_llm/visual_gen @NVIDIA/trt-llm-torch-visual-gen-devs @NVIDIA/trt-llm-runtime-devs
-/tests/integration/defs/examples/test_visual_gen.py @NVIDIA/trt-llm-torch-visual-gen-devs
+/tests/integration/defs/examples/visual_gen @NVIDIA/trt-llm-torch-visual-gen-devs


This change is already being made in #16683

~~good point, closing this PR.~~
#16683 is going to take a long time to merge, merge this codeowner change first.

tensorrt-cicd · 2026-07-27T18:42:12Z

PR_Github #61943 [ run ] completed with state FAILURE. Commit: 3c73d00
/LLM/main/L0_MergeRequest_PR pipeline #50133 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

yibinl-nvidia · 2026-07-27T18:55:22Z

/bot run

yibinl-nvidia · 2026-08-03T19:17:35Z

/bot run

tensorrt-cicd · 2026-08-03T19:23:08Z

PR_Github #63540 [ run ] triggered by Bot. Commit: 3c73d00 Link to invocation

tensorrt-cicd · 2026-08-03T21:04:34Z

PR_Github #63540 [ run ] completed with state SUCCESS. Commit: 3c73d00
/LLM/main/L0_MergeRequest_PR pipeline #51506 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

yibinl-nvidia · 2026-08-03T21:32:24Z

/bot run

tensorrt-cicd · 2026-08-03T21:38:46Z

PR_Github #63562 [ run ] triggered by Bot. Commit: 3c73d00 Link to invocation

tensorrt-cicd · 2026-08-04T01:19:40Z

PR_Github #63562 [ run ] completed with state FAILURE. Commit: 3c73d00
/LLM/main/L0_MergeRequest_PR pipeline #51528 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

yibinl-nvidia · 2026-08-04T01:37:09Z

/bot run

tensorrt-cicd · 2026-08-04T01:54:25Z

PR_Github #63611 [ run ] triggered by Bot. Commit: 3c73d00 Link to invocation

tensorrt-cicd · 2026-08-04T03:33:54Z

PR_Github #63611 [ run ] completed with state FAILURE. Commit: 3c73d00
/LLM/main/L0_MergeRequest_PR pipeline #51573 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

yibinl-nvidia · 2026-08-04T03:41:22Z

/bot run

tensorrt-cicd · 2026-08-04T03:46:39Z

PR_Github #63644 [ run ] triggered by Bot. Commit: 3c73d00 Link to invocation

tensorrt-cicd · 2026-08-04T06:39:19Z

PR_Github #63644 [ run ] completed with state SUCCESS. Commit: 3c73d00
/LLM/main/L0_MergeRequest_PR pipeline #51599 completed with status: 'SUCCESS'

CI Report

Link to invocation

yibinl-nvidia requested review from a team as code owners July 24, 2026 20:16

yibinl-nvidia requested review from EmmaQiaoCh and mlefeb01 July 24, 2026 20:16

github-actions Bot assigned yibinl-nvidia Jul 24, 2026

coderabbitai Bot mentioned this pull request Jul 24, 2026

[TRTLLM-14557][test] Add single-device visual-gen feature accuracy regression tests #16683

Open

7 tasks

Update VisualGen test CODEOWNERS

3c73d00

Signed-off-by: Yibin Li <109242046+yibinl-nvidia@users.noreply.github.com>

yibinl-nvidia force-pushed the dev-yibinl-codeowners-visualgen-tests branch from 5e45658 to 3c73d00 Compare July 27, 2026 03:09

tburt-nv reviewed Jul 27, 2026

View reviewed changes

yibinl-nvidia closed this Jul 28, 2026

yibinl-nvidia reopened this Aug 3, 2026

Uh oh!

Conversation

yibinl-nvidia commented Jul 24, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dev Engineer Review

QA Engineer Review

Description

Test Coverage

PR Checklist

GitHub Bot Help

Uh oh!

yibinl-nvidia commented Jul 24, 2026

Uh oh!

coderabbitai Bot commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

tensorrt-cicd commented Jul 24, 2026

Uh oh!

tensorrt-cicd commented Jul 24, 2026

Uh oh!

yibinl-nvidia commented Jul 27, 2026

Uh oh!

tensorrt-cicd commented Jul 27, 2026

Uh oh!

tensorrt-cicd commented Jul 27, 2026

Uh oh!

yibinl-nvidia commented Jul 27, 2026

Uh oh!

tensorrt-cicd commented Jul 27, 2026

Uh oh!

tburt-nv Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

yibinl-nvidia Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tensorrt-cicd commented Jul 27, 2026

Uh oh!

yibinl-nvidia commented Jul 27, 2026

Uh oh!

yibinl-nvidia commented Aug 3, 2026

Uh oh!

tensorrt-cicd commented Aug 3, 2026

Uh oh!

tensorrt-cicd commented Aug 3, 2026

Uh oh!

yibinl-nvidia commented Aug 3, 2026

Uh oh!

tensorrt-cicd commented Aug 3, 2026

Uh oh!

tensorrt-cicd commented Aug 4, 2026

Uh oh!

yibinl-nvidia commented Aug 4, 2026

Uh oh!

tensorrt-cicd commented Aug 4, 2026

Uh oh!

tensorrt-cicd commented Aug 4, 2026

Uh oh!

yibinl-nvidia commented Aug 4, 2026

Uh oh!

tensorrt-cicd commented Aug 4, 2026

Uh oh!

tensorrt-cicd commented Aug 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yibinl-nvidia commented Jul 24, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 24, 2026 •

edited

Loading

yibinl-nvidia Jul 28, 2026 •

edited

Loading