[https://nvbugs/6478715][fix] Renamed the worker's forward() to _forward_impl() so the base… - #16730
[https://nvbugs/6478715][fix] Renamed the worker's forward() to _forward_impl() so the base…#16730chenfeiz0326 wants to merge 1 commit into
Conversation
…rward_impl MTPEagleDynamicTreeWorker overrode SpecWorkerBase.forward, which the __init_subclass__ guard (nvbugs/6442074) forbids, raising TypeError at import time and breaking test collection. Rename to _forward_impl so the base SpecWorkerBase.forward wrapper drives it and retains its attn-metadata cleanup guarantee. Signed-off-by: Chenfei Zhang <chenfeiz@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe MTP dynamic tree worker’s top-level method is renamed from ChangesMTP dynamic tree worker
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
This is already on #16730 (nvbugs/6478715) and #16731 (nvbugs/6445316) are byte-identical to each other and to what merged, so both are no-ops. Suggest closing both and resolving the two bugs as duplicates of 6442074. |
Summary
Test plan
Links
Dev Engineer Review
MTPEagleDynamicTreeWorker.forward()to_forward_impl()soSpecWorkerBasecan retain control of the guardedforward()wrapper and perform attention-metadata cleanup.QA Engineer Review
No test changes.