[None][fix] avoid duplicate harmony tokenization & populate perf_metrics - #14506
Merged
longlee0622 merged 1 commit intoMay 27, 2026
Merged
Conversation
brb-nv
force-pushed
the
fix/disagg-chat-tokens-and-perf-metrics
branch
from
May 24, 2026 21:29
0df721f to
a81c0f2
Compare
… & populate /perf_metrics deque for chat endpoints Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
brb-nv
force-pushed
the
fix/disagg-chat-tokens-and-perf-metrics
branch
from
May 24, 2026 21:31
a81c0f2 to
7901019
Compare
Collaborator
Author
|
/bot run --disable-fail-fast |
Collaborator
|
PR_Github #50114 [ run ] triggered by Bot. Commit: |
reasonsolo
approved these changes
May 25, 2026
Collaborator
|
PR_Github #50114 [ run ] completed with state
|
1 task
1 task
brb-nv
added a commit
to brb-nv/TensorRT-LLM
that referenced
this pull request
May 29, 2026
…ics (NVIDIA#14506) Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
brb-nv
added a commit
to brb-nv/TensorRT-LLM
that referenced
this pull request
May 29, 2026
…ics (NVIDIA#14506) Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
brb-nv
added a commit
to brb-nv/TensorRT-LLM
that referenced
this pull request
May 29, 2026
…ator Addresses CodeRabbit feedback on PR NVIDIA#14719: - Split the bare `except:` introduced by NVIDIA#14506 in `chat_harmony.create_streaming_generator` into `except asyncio.CancelledError: raise` plus `except Exception: logger.error(...); raise`. The bare except previously swallowed `CancelledError` propagation and logged a misleading traceback on every client-initiated stream disconnect. - Drop `raise e` in favor of plain `raise` in the harmony tokenization error path to preserve the original traceback (PEP 8 / ruff B904). Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
brb-nv
added a commit
to brb-nv/TensorRT-LLM
that referenced
this pull request
May 29, 2026
…ReuseTreeByBlockKey (NVIDIA#14499) Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com> [None][fix] avoid duplicate harmony tokenization & populate perf_metrics (NVIDIA#14506) Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
brb-nv
added a commit
to brb-nv/TensorRT-LLM
that referenced
this pull request
May 29, 2026
…ReuseTreeByBlockKey (NVIDIA#14499) Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com> [None][fix] avoid duplicate harmony tokenization & populate perf_metrics (NVIDIA#14506) Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
brb-nv
added a commit
to brb-nv/TensorRT-LLM
that referenced
this pull request
May 29, 2026
…ReuseTreeByBlockKey (NVIDIA#14499) [https://nvbugs/6196391][fix] avoid duplicate harmony tokenization & populate perf_metrics (NVIDIA#14506) Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
brb-nv
added a commit
to brb-nv/TensorRT-LLM
that referenced
this pull request
May 29, 2026
…ReuseTreeByBlockKey (NVIDIA#14499) [https://nvbugs/6196391][fix] avoid duplicate harmony tokenization & populate perf_metrics (NVIDIA#14506) Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
brb-nv
added a commit
to brb-nv/TensorRT-LLM
that referenced
this pull request
May 29, 2026
…ReuseTreeByBlockKey (NVIDIA#14499) [https://nvbugs/6196391][fix] avoid duplicate harmony tokenization & populate perf_metrics (NVIDIA#14506) Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
reasonsolo
pushed a commit
to reasonsolo/TensorRT-LLM
that referenced
this pull request
Jun 2, 2026
…ics (NVIDIA#14506) Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
reasonsolo
pushed a commit
to reasonsolo/TensorRT-LLM
that referenced
this pull request
Jun 4, 2026
…ics (NVIDIA#14506) Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This MR makes the following changes:
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.