Skip to content

[None][fix] Exclude Qwen3 VL vision model from quantization - #12851

Merged
2ez4bz merged 1 commit into
NVIDIA:mainfrom
2ez4bz:dev-qwen3-vl-fp8-kv-cache-fix
May 27, 2026
Merged

[None][fix] Exclude Qwen3 VL vision model from quantization#12851
2ez4bz merged 1 commit into
NVIDIA:mainfrom
2ez4bz:dev-qwen3-vl-fp8-kv-cache-fix

Conversation

@2ez4bz

@2ez4bz 2ez4bz commented Apr 8, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Refactor
    • Updated KV cache quantization configuration initialization for the vision encoder in Qwen3VL models.

Review Change Stack

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Comment thread tensorrt_llm/_torch/models/modeling_qwen3vl.py
@2ez4bz
2ez4bz marked this pull request as ready for review May 11, 2026 17:07
@2ez4bz
2ez4bz requested review from a team as code owners May 11, 2026 17:07
@2ez4bz
2ez4bz requested review from moraxu and yechank-nvidia May 11, 2026 17:07
@2ez4bz
2ez4bz force-pushed the dev-qwen3-vl-fp8-kv-cache-fix branch from 547c073 to 795a373 Compare May 11, 2026 17:08
@2ez4bz

2ez4bz commented May 11, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai

coderabbitai Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9219dc00-0524-4077-866e-8519e467d234

📥 Commits

Reviewing files that changed from the base of the PR and between 5f3fd3a and 795a373.

📒 Files selected for processing (1)
  • tensorrt_llm/_torch/models/modeling_qwen3vl.py

📝 Walkthrough

Walkthrough

The PR modifies Qwen3VLModelBase initialization to reset the quantization configuration to a plain QuantConfig() instead of preserving the previous KV cache quantization algorithm. The accompanying comment is updated to reflect the exclusion of KV cache quantization for the vision encoder.

Changes

Quantization Config Initialization

Layer / File(s) Summary
Model Init Quantization Config Reset
tensorrt_llm/_torch/models/modeling_qwen3vl.py
Qwen3VLModelBase vision wrapper initialization resets self.model_config.quant_config to QuantConfig(), dropping the previous kv_cache_quant_algo passthrough. The comment is updated to document that KV cache quantization is excluded for the vision encoder.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete; it contains only the template with no actual content in Description, Test Coverage, or specific PR details sections. Fill in the Description section explaining the issue and rationale, add Test Coverage section listing relevant tests, and provide specific details in the PR Checklist.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: excluding Qwen3 VL vision model from quantization, which aligns with the code change of re-initializing quantization config.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #47782 [ run ] triggered by Bot. Commit: 795a373 Link to invocation

@2ez4bz
2ez4bz enabled auto-merge (squash) May 11, 2026 18:09
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #47782 [ run ] completed with state SUCCESS. Commit: 795a373
/LLM/main/L0_MergeRequest_PR pipeline #37674 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@2ez4bz

2ez4bz commented May 12, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #47914 [ run ] triggered by Bot. Commit: 795a373 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #47914 [ run ] completed with state SUCCESS. Commit: 795a373
/LLM/main/L0_MergeRequest_PR pipeline #37761 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@yechank-nvidia

Copy link
Copy Markdown
Collaborator

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #47932 [ run ] triggered by Bot. Commit: 795a373 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #47932 [ run ] completed with state SUCCESS. Commit: 795a373
/LLM/main/L0_MergeRequest_PR pipeline #37778 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@2ez4bz
2ez4bz force-pushed the dev-qwen3-vl-fp8-kv-cache-fix branch from 795a373 to 96f1e7a Compare May 21, 2026 20:13
@2ez4bz

2ez4bz commented May 21, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49759 [ run ] triggered by Bot. Commit: 96f1e7a Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49759 [ run ] completed with state SUCCESS. Commit: 96f1e7a
/LLM/main/L0_MergeRequest_PR pipeline #39359 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@2ez4bz

2ez4bz commented May 21, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49777 [ run ] triggered by Bot. Commit: 96f1e7a Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49777 [ run ] completed with state SUCCESS. Commit: 96f1e7a
/LLM/main/L0_MergeRequest_PR pipeline #39374 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Signed-off-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>
@2ez4bz
2ez4bz force-pushed the dev-qwen3-vl-fp8-kv-cache-fix branch from 96f1e7a to ec466d1 Compare May 26, 2026 22:44
@2ez4bz

2ez4bz commented May 26, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50399 [ run ] triggered by Bot. Commit: ec466d1 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50399 [ run ] completed with state SUCCESS. Commit: ec466d1
/LLM/main/L0_MergeRequest_PR pipeline #39923 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@2ez4bz

2ez4bz commented May 27, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50452 [ run ] triggered by Bot. Commit: ec466d1 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50452 [ run ] completed with state SUCCESS. Commit: ec466d1
/LLM/main/L0_MergeRequest_PR pipeline #39971 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

CI Report

Link to invocation

@2ez4bz
2ez4bz merged commit 5a5d093 into NVIDIA:main May 27, 2026
7 checks passed
bmarimuthu-nv pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request May 28, 2026
…2851)

Signed-off-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>
yechank-nvidia pushed a commit to yechank-nvidia/TensorRT-LLM that referenced this pull request May 29, 2026
…2851)

Signed-off-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants