fix(bootstrap): detect low inotify limits before gateway startup#654
Closed
RPirruccio wants to merge 1 commit intoNVIDIA:mainfrom
Closed
fix(bootstrap): detect low inotify limits before gateway startup#654RPirruccio wants to merge 1 commit intoNVIDIA:mainfrom
RPirruccio wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
…DIA#552) The embedded k3s cluster and its components (containerd, kubelet, flannel, CoreDNS) create many inotify instances. On hosts that already run Kubernetes or other container workloads, the default fs.inotify.max_user_instances limit (128) can be exhausted, causing containerd's CRI plugin to fail with "too many open files" when creating its fsnotify watcher. This prevents the RuntimeService from registering, which surfaces as the opaque "K8s namespace not ready" timeout. Add inotify limit checks in two places: 1. cluster-entrypoint.sh: warn before starting k3s if the limit is below 256. Prints the current value and the exact fix command. Does not auto-modify kernel parameters -- enterprise environments may audit sysctl changes. 2. doctor_check() in the CLI: adds an inotify instances check after the existing Docker check, so `openshell doctor check` catches the issue diagnostically. Closes NVIDIA#552 Signed-off-by: Riccardo Pirruccio <rickp1795@gmail.com>
|
Thank you for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot. |
|
Thank you for your interest in contributing to OpenShell, @RPirruccio. This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer. To get vouched:
See CONTRIBUTING.md for details. |
Author
|
I have read the DCO document and I hereby sign the DCO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Detect low
fs.inotify.max_user_instancesbefore k3s starts and surface it inopenshell doctor check. On hosts running existing container workloads, the default limit (128) can be exhausted, causing containerd's CRI plugin to fail with "too many open files" when creating its fsnotify watcher. The RuntimeService never registers, which surfaces as the "K8s namespace not ready" timeout.The fix is warn-only. It doesn't change any kernel params, just tells you what's wrong and how to fix it yourself.
Related Issue
Related to #552
Changes
cluster-entrypoint.sh: check inotify limit before starting k3s, warn if below 256 with exact fix commanddoctor_check()inrun.rs: add inotify instances check (Linux only) after existing Docker checkTesting
Tested on Ubuntu 24.04, Docker 29.0.4, kernel 6.17.0 with existing k3s cluster on host. Root cause confirmed via
docker exec:sudo sysctl -w fs.inotify.max_user_instances=512resolved immediately.mise run pre-commitpassesChecklist