Skip to content

📝 CodeRabbit Chat: Implement requested code changes #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
coderabbitai wants to merge 1 commit into from
Closed

📝 CodeRabbit Chat: Implement requested code changes #1232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .claude/skills/ptq/references/slurm-setup-ptq.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,16 @@ If enroot import fails (e.g., permission errors on lustre), use pyxis inline pul

### Container dependency pitfalls

**New models may need newer transformers** than what's in the container. Install from source inside the job script:
**New models may need newer transformers** than what's in the container. Install from PyPI inside the job script (unset `PIP_CONSTRAINT` first if needed — see below):

```bash
pip install git+https://github.com/huggingface/transformers.git --quiet
pip install -U transformers
```

Only install from git if the fix you need isn't in a released version yet:

```bash
pip install git+https://github.com/huggingface/transformers.git
```

**Prefer `PYTHONPATH`** to use the synced ModelOpt source instead of installing inside the container — this avoids risking dependency conflicts (e.g., `pip install -U nvidia-modelopt[hf]` can upgrade PyTorch and break other packages):
Expand Down Expand Up @@ -90,4 +96,4 @@ This catches script errors cheaply before using GPU quota on a real run.

See `skills/common/slurm-setup.md` section 2 for the smoke test partition pattern.

Only submit the full calibration job after the smoke test exits cleanly.
Only submit the full calibration job after the smoke test exits cleanly.