fix(docs): explain removed setup commands - #297
Conversation
Signed-off-by: Elyas Mehtabuddin <emehtabuddin@nvidia.com>
|
WalkthroughThe CLI reference now documents removed setup commands, required credential and deployment handling, and dry-run validation. Tests verify documentation ordering, required statements, and the absence of ChangesCLI reference updates
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/test_cli_reference_docs.py`:
- Around line 44-52: Update test_reference_marks_removed_setup_commands to bound
the removed text between “## Removed Setup Commands” and “## Related
Documentation” before asserting its contents. Keep the existing command
availability and statement assertions, but ensure they only inspect the
removed-command section.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: d79ff51f-4add-40f9-9ea9-15605879d571
📒 Files selected for processing (2)
docs/cli_reference.mdtests/test_cli_reference_docs.py
Signed-off-by: Elyas Mehtabuddin <emehtabuddin@nvidia.com>
…mples Signed-off-by: Elyas Mehtabuddin <emehtabuddin@nvidia.com>
The current CLI prints:
configureandverifywere deliberately removed when the CLI was narrowed toserveandlaunch, but the CLI reference only omits them. A reader cannot tell whether the commands moved or were removed.This PR records the removal and the supported replacement: name the credential environment variable with
api_key_env, export it, pass the TOML deployment to eachlaunch, and useswitchyard-server --dry-runto validate a native deployment. It does not restore saved credentials, saved deployment paths, or either removed command.The documented replacement is:
How tested
make publishfromdocs/builds the site in strict mode.uv run pytest tests/test_cli_reference_docs.py -v -o addopts=passes all four tests.test_reference_marks_removed_setup_commandsfails againstmainbecause the migration note is absent, and it also checks that the parser still excludes both removed commands.This documentation change does not alter CLI behavior.
Summary by CodeRabbit
Documentation
switchyard configureandswitchyard verifyare no longer available.switchyard-server --dry-run.Tests