test(ci): accept SHA-pinned claude-review template refs in the policy test#3022
Merged
akoumpa merged 1 commit intoJul 11, 2026
Merged
Conversation
… test Signed-off-by: khazic <khazzz1c@gmail.com>
HuiyingLi
approved these changes
Jul 11, 2026
akoumpa
approved these changes
Jul 11, 2026
Contributor
|
I've manually confirmed this fix; FMing |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
test_review_workflow_keeps_main_caller_wiringasserts the exactuses:ref of the claude-review caller workflow (_claude_review.yml@v1.7.0). #3013 repinned the template to a full commit SHA (7d857ec #v1.8.3) without updating the assertion, so the test now fails onmainand on every PR whose CI merges with currentmain(first seen as anaea1fdfmismatch during the v1.8.2 window, e.g. theL0_Unit_Tests_CPUfailure on #3002).This keeps the security intent of the test (the callee repo and workflow path must stay exactly
NVIDIA-NeMo/FW-CI-templates/.github/workflows/_claude_review.yml) while allowing the ref to move between release tags (vX.Y.Z) and full 40-hex commit SHAs, so routine repins of the template no longer breakmain.Verification
tests/unit_tests/test_claude_review_policy.pypasses against the current SHA-pinned workflow (84 passed), and the ref regex still accepts the previous tag form (v1.7.0). Auses:pointing at any other repo, path, or a non-tag/non-SHA ref still fails the test.