Skip to content

test(ci): accept SHA-pinned claude-review template refs in the policy test#3022

Merged
akoumpa merged 1 commit into
NVIDIA-NeMo:mainfrom
khazic:khazic/fix/claude-review-pin-test
Jul 11, 2026
Merged

test(ci): accept SHA-pinned claude-review template refs in the policy test#3022
akoumpa merged 1 commit into
NVIDIA-NeMo:mainfrom
khazic:khazic/fix/claude-review-pin-test

Conversation

@khazic

@khazic khazic commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

What

test_review_workflow_keeps_main_caller_wiring asserts the exact uses: ref of the claude-review caller workflow (_claude_review.yml@v1.7.0). #3013 repinned the template to a full commit SHA (7d857ec #v1.8.3) without updating the assertion, so the test now fails on main and on every PR whose CI merges with current main (first seen as an aea1fdf mismatch during the v1.8.2 window, e.g. the L0_Unit_Tests_CPU failure on #3002).

This keeps the security intent of the test (the callee repo and workflow path must stay exactly NVIDIA-NeMo/FW-CI-templates/.github/workflows/_claude_review.yml) while allowing the ref to move between release tags (vX.Y.Z) and full 40-hex commit SHAs, so routine repins of the template no longer break main.

Verification

tests/unit_tests/test_claude_review_policy.py passes against the current SHA-pinned workflow (84 passed), and the ref regex still accepts the previous tag form (v1.7.0). A uses: pointing at any other repo, path, or a non-tag/non-SHA ref still fails the test.

… test

Signed-off-by: khazic <khazzz1c@gmail.com>
@copy-pr-bot

copy-pr-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@HuiyingLi HuiyingLi enabled auto-merge (squash) July 11, 2026 02:06
@akoumpa akoumpa disabled auto-merge July 11, 2026 05:59
@akoumpa

akoumpa commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

I've manually confirmed this fix; FMing

@akoumpa akoumpa merged commit 7f3c352 into NVIDIA-NeMo:main Jul 11, 2026
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants