Send slack notification on failed GHA jobs #346
Merged
+40
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview |
02f48ed to
18bd6ed
Compare
e9dd203 to
2a5c3e1
Compare
nv-alaiacano
commented
May 15, 2023
| pull_request: | ||
| branches: [main] | ||
|
|
||
| concurrency: |
Contributor
Author
There was a problem hiding this comment.
Unrelated to slack notification, but should be here.
jperez999
approved these changes
May 16, 2023
jperez999
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sends a message to a slack webhook if the "postmerge" actions fail. It can be considered the first step of NVIDIA-Merlin/Merlin#977 - once this works (it sure is hard to test code that executes after a PR runs), I'll move the
stepto its own file so it can be easily reused across all of our actions and repos.I was able to verify that it works by adding it to
lint.yamlwith a run clause:if: ${{ success() && github.ref == 'refs/pull/346/merge' }}, so I'm fairly confident that it will work in the postmerge actions on the main branch ref.