Revert "Remove the Triton-specific Workflow execution code (#309)" #313
+777
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschifferer
approved these changes
Apr 5, 2023
Documentation preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f3541f6.
Removing the Triton-specific Workflow execution code bypassed the code that explicitly saved the Workflow out to a sub-directory of the Triton model repository, which had the side-effect of not saving the Categorify category files. The tests still passed because the Workflow is also pickled inside the Ensemble, and we don't have any tests that:
...both of which are required to reproduce the issue with loading category files since fitting a Workflow has the side effect of writing category files out to the current working directory.