Fix PredictTensorflow args in session-based serving integration test#310
Merged
karlhigley merged 1 commit intoNVIDIA-Merlin:mainfrom Apr 3, 2023
Merged
Conversation
jperez999
approved these changes
Apr 1, 2023
Collaborator
jperez999
left a comment
There was a problem hiding this comment.
This is much cleaner!
Documentation preview |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that this test was passing somewhat accidentally, because it supplied two arguments that were no longer required and the
PredictTensorflowoperator accepted enough arguments that didn't break the test to make that work. After the recent changes that removed Triton ensemble code in systems/pulls/305, there are no longer enough params for that to work, which breaks the test. This removes the extra and unnecessary params.