Skip to content

Return the original predicted scores from SoftmaxSampling #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karlhigley merged 4 commits into from
Feb 16, 2023
Merged

Return the original predicted scores from SoftmaxSampling #290

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6dcd5c
Return the original predicted scores from `SoftmaxSampling`
karlhigley Feb 15, 2023
58f21ea
Update the output schema of `SoftmaxSampling` to match
karlhigley Feb 15, 2023
77b76bb
Merge branch 'main' into feature/softmax-scores
karlhigley Feb 16, 2023
ff85a13
Fix output scores dtype
karlhigley Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions merlin/systems/dag/ops/softmax_sampling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,12 @@ def compute_output_schema(
self, input_schema: Schema, col_selector: ColumnSelector, prev_output_schema: Schema = None
) -> Schema:
"""Describe the operator's outputs"""
return Schema([ColumnSchema("ordered_ids", dtype=np.int32, dims=(None, 1))])
return Schema(
[
ColumnSchema("ordered_ids", dtype=np.int32, dims=(None, 1)),
ColumnSchema("ordered_scores", dtype=np.float32, dims=(None, 1)),
]
)

def transform(
self, col_selector: ColumnSelector, transformable: Transformable
Expand Down Expand Up @@ -133,6 +138,10 @@ def transform(
# This is just bookkeeping to produce the final ordered list of recs
sorted_indices = np.argsort(exponentials)
topk_item_ids = candidate_ids[sorted_indices][: self.topk]
topk_item_scores = predicted_scores[sorted_indices][: self.topk]
ordered_item_ids = topk_item_ids.reshape(1, -1).T
ordered_item_scores = topk_item_scores.reshape(1, -1).T

return type(transformable)({"ordered_ids": ordered_item_ids})
return type(transformable)(
Comment thread
karlhigley marked this conversation as resolved.
{"ordered_ids": ordered_item_ids, "ordered_scores": ordered_item_scores}
)