Error propagation from tritonserver for nvtabular workflow#277
Merged
karlhigley merged 11 commits intoNVIDIA-Merlin:mainfrom Feb 15, 2023
Merged
Error propagation from tritonserver for nvtabular workflow#277karlhigley merged 11 commits intoNVIDIA-Merlin:mainfrom
karlhigley merged 11 commits intoNVIDIA-Merlin:mainfrom
Conversation
Documentation preview |
karlhigley
reviewed
Jan 24, 2023
|
|
||
| # check inference response for errors: | ||
| if inference_response.has_error(): | ||
| # Cannot raise inference response error because it is not derived from BaseException |
karlhigley
approved these changes
Jan 24, 2023
Contributor
|
Looks like the test for this uses something that isn't available from the installed version of the package: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces error propagation from tritonserver. Allowing failures in Tritonserver to properly display for users. Giving them more valuable information about what is happening under the hood. This pattern can be implemented for all triton operators. This PR focuses on nvtabular.