feast should return np.float32 not np.float by default

[nv-alaiacano]

A potential solution for #177 (still to be verified).

We return np.float which is a deprecated alias for np.float64. However, when we infer the input schemas in PredictTensorflow, continuously valued model inputs are np.float32, thus we get a schema mis-match when we chain QueryFeast into PredictTensorflow.

[nvidia-merlin-bot]

Click to view CI Results

GitHub pull request #178 of commit 0966faaf2c6ab6b6d75b292dcde6305240620eb5, no merge conflicts.
Running as SYSTEM
Setting status of 0966faaf2c6ab6b6d75b292dcde6305240620eb5 to PENDING with url https://10.20.13.93:8080/job/merlin_systems/304/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_systems
using credential fce1c729-5d7c-48e8-90cb-b0c314b1076e
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/systems # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/systems
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems user + githubtoken
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/systems +refs/pull/178/*:refs/remotes/origin/pr/178/* # timeout=10
 > git rev-parse 0966faaf2c6ab6b6d75b292dcde6305240620eb5^{commit} # timeout=10
Checking out Revision 0966faaf2c6ab6b6d75b292dcde6305240620eb5 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 0966faaf2c6ab6b6d75b292dcde6305240620eb5 # timeout=10
Commit message: "feast should return np.float32 not np.float by default"
 > git rev-list --no-walk f2e9c42ea78dfb4c46c478aaf8d9161362e04f7a # timeout=10
[merlin_systems] $ /bin/bash /tmp/jenkins8318527460320415350.sh
PYTHONPATH=:/usr/local/lib/python3.8/dist-packages/:/usr/local/hugectr/lib:/var/jenkins_home/workspace/merlin_systems/systems
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_systems/systems, configfile: pyproject.toml
plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 68 items
tests/unit/test_version.py .                                             [  1%]

tests/unit/examples/test_serving_an_xgboost_model_with_merlin_systems.py . [  2%]

[  2%]

tests/unit/examples/test_serving_ranking_models_with_merlin_systems.py . [  4%]

[  4%]

tests/unit/systems/test_export.py .                                      [  5%]

tests/unit/systems/dag/test_graph.py ..                                  [  8%]

tests/unit/systems/dag/test_model_registry.py ..                         [ 11%]

tests/unit/systems/dag/test_op_runner.py ....                            [ 17%]

tests/unit/systems/dag/ops/test_ops.py ..                                [ 20%]

tests/unit/systems/ops/feast/test_op.py .....                            [ 27%]

tests/unit/systems/ops/fil/test_ensemble.py .                            [ 29%]

tests/unit/systems/ops/fil/test_forest.py ....                           [ 35%]

tests/unit/systems/ops/fil/test_op.py ..........................         [ 73%]

tests/unit/systems/ops/implicit/test_op.py ......                        [ 82%]

tests/unit/systems/ops/nvtabular/test_op.py ..                           [ 85%]

tests/unit/systems/ops/tf/test_ensemble.py ..                            [ 88%]

tests/unit/systems/ops/tf/test_op.py ....                                [ 94%]

tests/unit/systems/ops/torch/test_op.py ....                             [100%]
=============================== warnings summary ===============================

../../../../../usr/local/lib/python3.8/dist-packages/nvtabular/framework_utils/init.py:18

/usr/local/lib/python3.8/dist-packages/nvtabular/framework_utils/init.py:18: DeprecationWarning: The nvtabular.framework_utils module is being replaced by the Merlin Models library. Support for importing from nvtabular.framework_utils is deprecated, and will be removed in a future version. Please consider using the models and layers from Merlin Models instead.

warnings.warn(
tests/unit/examples/test_serving_ranking_models_with_merlin_systems.py: 1 warning

tests/unit/systems/test_export.py: 1 warning

tests/unit/systems/dag/test_op_runner.py: 4 warnings

tests/unit/systems/ops/nvtabular/test_op.py: 2 warnings

tests/unit/systems/ops/tf/test_ensemble.py: 2 warnings

/usr/local/lib/python3.8/dist-packages/cudf/core/frame.py:384: UserWarning: The deep parameter is ignored and is only included for pandas compatibility.

warnings.warn(
tests/unit/systems/test_export.py::test_export_run_ensemble_triton[tensorflow-parquet]

/var/jenkins_home/workspace/merlin_systems/systems/merlin/systems/triton/export.py:304: UserWarning: Column x is being generated by NVTabular workflow  but is unused in test_name_tf model

warnings.warn(
tests/unit/systems/test_export.py::test_export_run_ensemble_triton[tensorflow-parquet]

/var/jenkins_home/workspace/merlin_systems/systems/merlin/systems/triton/export.py:304: UserWarning: Column y is being generated by NVTabular workflow  but is unused in test_name_tf model

warnings.warn(
tests/unit/systems/test_export.py::test_export_run_ensemble_triton[tensorflow-parquet]

/var/jenkins_home/workspace/merlin_systems/systems/merlin/systems/triton/export.py:304: UserWarning: Column id is being generated by NVTabular workflow  but is unused in test_name_tf model

warnings.warn(
tests/unit/systems/ops/fil/test_forest.py::test_export_merlin_models

/usr/local/lib/python3.8/dist-packages/tornado/ioloop.py:350: DeprecationWarning: make_current is deprecated; start the event loop first

self.make_current()
tests/unit/systems/ops/fil/test_op.py::test_binary_classifier_default[sklearn_forest_classifier-get_model_params4]

tests/unit/systems/ops/fil/test_op.py::test_binary_classifier_with_proba[sklearn_forest_classifier-get_model_params4]

tests/unit/systems/ops/fil/test_op.py::test_multi_classifier[sklearn_forest_classifier-get_model_params4]

tests/unit/systems/ops/fil/test_op.py::test_regressor[sklearn_forest_regressor-get_model_params4]

tests/unit/systems/ops/fil/test_op.py::test_model_file[sklearn_forest_regressor-checkpoint.tl]

/usr/local/lib/python3.8/dist-packages/sklearn/utils/deprecation.py:103: FutureWarning: Attribute n_features_ was deprecated in version 1.0 and will be removed in 1.2. Use n_features_in_ instead.

warnings.warn(msg, category=FutureWarning)
tests/unit/systems/ops/implicit/test_op.py::test_reload_from_config[AlternatingLeastSquares]

/usr/local/lib/python3.8/dist-packages/implicit/utils.py:28: UserWarning: OpenBLAS detected. Its highly recommend to set the environment variable 'export OPENBLAS_NUM_THREADS=1' to disable its internal multithreading

warnings.warn(
tests/unit/systems/ops/torch/test_op.py::test_pytorch_op_serving[True-True]

/usr/local/lib/python3.8/dist-packages/torch/serialization.py:707: UserWarning: 'torch.load' received a zip file that looks like a TorchScript archive dispatching to 'torch.jit.load' (call 'torch.jit.load' directly to silence this warning)

warnings.warn("'torch.load' received a zip file that looks like a TorchScript archive"
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

================= 68 passed, 22 warnings in 296.47s (0:04:56) ==================

Performing Post build task...

Match found for : : True

Logical operation result is TRUE

Running script  : #!/bin/bash

cd /var/jenkins_home/

CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/systems/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"

[merlin_systems] $ /bin/bash /tmp/jenkins4644432225186690399.sh

[github-actions]

Documentation preview

https://nvidia-merlin.github.io/systems/review/pr-178