Fix build system for windows targets#38
Fix build system for windows targets#38RobbieG15 wants to merge 2 commits intoNVIDIA-ISAAC-ROS:mainfrom
Conversation
Greptile SummaryAdds an explicit Confidence Score: 5/5Safe to merge — single-line correctness fix with no behavior change on Linux and correct behavior on Windows. The change is minimal, well-targeted, and uses the standard idiomatic solution for cross-platform chrono portability. No logic or data-integrity concerns. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant Caller
participant GetTimestamp
participant chrono
Caller->>GetTimestamp: GetTimestampFromSerializedMessage(msg)
GetTimestamp->>GetTimestamp: Extract sec/nsec from buffer[4..11]
GetTimestamp->>chrono: seconds(sec) + nanoseconds(nsec)
chrono-->>GetTimestamp: combined nanoseconds duration
GetTimestamp->>chrono: duration_cast<system_clock::duration>(combined)
Note over chrono: Linux: no-op (already nanoseconds)<br/>Windows: truncates to 100ns ticks
chrono-->>GetTimestamp: platform-native duration
GetTimestamp-->>Caller: time_point<system_clock>
Reviews (3): Last reviewed commit: "Fix the linting errors" | Re-trigger Greptile |
|
Hi @RobbieG15, thanks! Happy to merge this. Looks like some linting errors on older distros and I don't think the commit was signed. Both pre commit hooks for linting and the sign off instructions can be found here: https://github.com/NVIDIA-ISAAC-ROS/greenwave_monitor/blob/main/Contributing.md |
ce14bbb to
d66a4b7
Compare
Signed-off-by: Robert Greenslade <robert.greenslade@resonantsciences.com> Signed-off-by: Robert Greenslade <robbieg1515@gmail.com>
Signed-off-by: Robert Greenslade <robert.greenslade@resonantsciences.com> Signed-off-by: Robert Greenslade <robbieg1515@gmail.com>
d66a4b7 to
c5fe2f3
Compare
|
Those linting/format errors should be resolved and all tests are passing. I also signed the commits. Let me know if there is anything else I should do. Thanks! |
This will fix windows build systems.
There is a stricter usage of Chrono with windows and MSVC.
Thank you for all the work on this project.
Let me know if there is anything else I can do if this does not fix it for you all.
I verified that this works on my windows machine.