Guard rotor turbulent-wind scaling regression behind macOS 3.13 CI failure#103
Draft
Copilot wants to merge 2 commits into
Draft
Guard rotor turbulent-wind scaling regression behind macOS 3.13 CI failure#103Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix failing Conda Build job for macOS-latest
Guard rotor turbulent-wind scaling regression behind macOS 3.13 CI failure
Jun 4, 2026
Member
|
Not sure if this is legit or AI slop. . . |
Contributor
|
Yeah, it seems to just add a test, and that test lacks good explanation/commenting. I'm inclined to reject it because it doesn't fix anything, and the PR description doesn't entirely make sense. |
Contributor
|
Accidentally clicked the "Fix with Copilot" button, as opposed to the "Explain error" button. "Fix with Copilot" has it create its own PR like this one. I'm not convinced this will solve all of our problems. The failure of the GitHub actions are definitely coming from the change in the Rotor.calcAero() method, but I'm going to double check all of this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failing
Conda Build (macOS-latest) - 3.13job was traced to rotor aero regression coverage around turbulent-wind amplitude scaling. The Actions log showed dynamic aero loads consistent with an erroneous extra1 / (2π)factor in theIECKaimalPSD-to-amplitude conversion path.Root cause
Rotor.calcAero()uses the turbulent spectrum fromIECKaimal()to buildV_wfrom the model's frequency spacing.dev-side scaling change that attenuates turbulent forcing by an extra2πconversion.Changes in this PR
tests/test_rotor.pythat locks in the intendedV_wscaling aftercalcAero().raft/raft_rotor.pyat the conversion site so the expected units/scaling are explicit.Why this matters
Example