Open
Conversation
martialblog
commented
Feb 6, 2026
| type Status int | ||
|
|
||
| const ( | ||
| Invalid Status = iota - 1 |
Member
Author
There was a problem hiding this comment.
Not sure about this one. I kinda wanted something to "mean" error/invalid and we use a -1 value in result.WorstState.
Member
There was a problem hiding this comment.
That is one problem of the whole monitoring plugins interface, there is no "error" state
Member
Author
There was a problem hiding this comment.
Any ideas? just use Unknown and add some custom error types?
Member
There was a problem hiding this comment.
hm, we could keep an "error" code and map it to "UNKNOWN" at exit, that would be nice from a programer perspective, but also confusing since the end is the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the v1 Release we want to introduce a proper State Type for the v1.0.0 - that type can then just implement the Stringer interface and have a NewFromInt/String function.
Fixes #125
This also changes check.ExitRaw to Exit and removes the Exitf.