feat(cross-platform-smoke): install_command input; release 0.13.3 - #64
Merged
Conversation
The only reusable that runs a caller command across an OS matrix had no way to install that command's dependencies, so callers chained the installer onto each per-OS override — duplicating it and reporting a broken install as a smoke failure. The step runs before the smoke command on every OS, is skipped when empty, and takes its value through env like every other caller-supplied string. Signed-off-by: Danil Silantyev <danilsilantyevwork@gmail.com>
Ships the privileged-ref guard and the pr-title permission fix that have been sitting on main since 0.13.2, so consumers can pin a tag instead of an untagged commit. Signed-off-by: Danil Silantyev <danilsilantyevwork@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
install_commandinput tocross-platform-smoke.yml— the only reusable that runs a caller command across an OS matrix with no way to install that command's dependencies first.private-static.ymlhas had one all along.mainsince 0.13.2: the fail-closed privileged-ref guard (Security) and thepr-titlepull-requests: readfix.Why now
github-device-synccurrently pinspr-hygiene.ymlto the untagged commit80234cbbecause the fix it needs is unreleased. Releasing 0.13.3 lets every consumer go back to pinning a tag, and gets the security guard to consumers who are on 0.13.2 today.Permissions diff
None. No job's
permissions:block changes.Threat model
The new step takes the caller string through
env:and runsbash -c "$INSTALL_COMMAND", identical to the existing "Run smoke command" step — no\${{ }}interpolation insiderun:, so template injection stays impossible. A caller could already run arbitrary commands viacommand; this adds no new capability, only a separate step so install failures are distinguishable from smoke failures. Skipped entirely when empty.Verification
Catalog, generated docs, tier doc, and the caller example are updated in step per
nddev-change-flow.cross-platform-smoke.ymlisunverifiedinruntime-coverage.yml, so no proven digest is invalidated.