Fix bug in certain cyclic subsets#782
Merged
davidhassell merged 5 commits intoNCAS-CMS:mainfrom Jun 11, 2024
Merged
Conversation
davidhassell
approved these changes
Jun 11, 2024
Collaborator
davidhassell
left a comment
There was a problem hiding this comment.
Hi Matt,
All good - thanks! If you could look at the one very minor change to the Changelog, and would you like to add your name to the contributors list in docs/source/contributing.rst?
Co-authored-by: David Hassell <davidhassell@users.noreply.github.com>
…on into fix_cyclic_subset_bug
Contributor
Author
|
Sure thing, all done :) |
Collaborator
|
Great, merging now. We'll be pushing out a the new version in the next few weeks (at least by the 8th July). Thanks again, Matt! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix #774