Fix cf.aggregate for actual_range and np.array properties#765
Merged
davidhassell merged 12 commits intoNCAS-CMS:mainfrom Apr 25, 2024
Merged
Fix cf.aggregate for actual_range and np.array properties#765davidhassell merged 12 commits intoNCAS-CMS:mainfrom
cf.aggregate for actual_range and np.array properties#765davidhassell merged 12 commits intoNCAS-CMS:mainfrom
Conversation
sadielbartholomew
approved these changes
Apr 24, 2024
Member
sadielbartholomew
left a comment
There was a problem hiding this comment.
Fixes the issue at hand, with good coverage from new testing to expose the bugs (added tests fail on main in the same manner as the bug report, which is always a good sign). I have minor comments but happy overall so merge when ready.
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #764
cf.aggregatethat caused a failure when properties arenumpyarrays with two or more elementscf.aggregatethat didn't correctly handle the "actual_range" CF attributeNote
The
_equalsmethod can cope with string-valued arguments, so we can simplify the block of code in which it appears