1-d Z Cartesian regridding fix and test#750
Merged
davidhassell merged 1 commit intoNCAS-CMS:mainfrom Mar 26, 2024
Merged
Conversation
sadielbartholomew
approved these changes
Mar 26, 2024
Member
sadielbartholomew
left a comment
There was a problem hiding this comment.
I have confirmed that this isolates the bug with a test and fixes it in a logical way. We should probably add a Changelog entry so we don't lose track of the fix, so ideally add one now here, but otherwise this is all good, so please merge.
Collaborator
Author
|
No need for a new change log entrry, as the existing covers it - this PR is raised against that issue. |
Member
|
Oh fair, good point. Thanks David. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix for #715
Discovered when this tutorial example code failed with
ValueError: Z coordinate 'dimensioncoordinate0' must match exactly an element of 'axes' (['domainaxis0'])