3-d spherical regridding and regridding to DSG feature types#726
Merged
davidhassell merged 31 commits intoNCAS-CMS:mainfrom Mar 6, 2024
Merged
3-d spherical regridding and regridding to DSG feature types#726davidhassell merged 31 commits intoNCAS-CMS:mainfrom
davidhassell merged 31 commits intoNCAS-CMS:mainfrom
Conversation
…tical axis in logarithmic coordinates
Member
|
Thanks for the notes for review David. Is this ready for review now or shall I wait? |
Collaborator
Author
|
Good to go ... |
Member
sadielbartholomew
left a comment
There was a problem hiding this comment.
Just finalising some functional reviews, but here are my minor comments from eyeballing the code.
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
sadielbartholomew
approved these changes
Mar 6, 2024
Member
There was a problem hiding this comment.
I am happy with all of the functionality introduced/changed here. It works including for our work towards VISION goals, as discussed externally.
Thanks for addressing the feedback from my previous review set. Everything looks good to me, now, and the full test suite is passing locally.
There's one spurious line now in the changelog, but once that is removed, please merge.
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #715 and #716
Notes
Griddataclass for locstream and vertical regridding parametersesmpy.Gridinstances so that 3-d spherical grids are included without any extra special treatmentesmpy.Locstreaminstances