This repository was archived by the owner on Feb 3, 2025. It is now read-only.
Wrap fedimint around an async rwlock#924
Merged
benthecarman merged 1 commit intomasterfrom Jan 2, 2024
Merged
Conversation
benthecarman
approved these changes
Jan 2, 2024
Collaborator
benthecarman
left a comment
There was a problem hiding this comment.
lgtm, I presume this is needed because before we couldn't read at the same time but with this we can
Contributor
Author
Correct, it was blocking the activity list while a fedimint payment was being made. |
Collaborator
|
There's probably other places in the codebase we can do this too, would be a good followup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.